Add sparse_vector field type #2304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pquentin
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
Thanks! LGTM.
By the way I think the documentation is missing for that field in the Elasticsearch docs. I can see rank_feature but not sparse_vector: https://www.elastic.co/guide/en/elasticsearch/reference/master/rank-feature.html
github-actions bot
pushed a commit
that referenced
this pull request
Oct 6, 2023
(cherry picked from commit e34cdb6)
pquentin
pushed a commit
that referenced
this pull request
Oct 6, 2023
* Add sparse_vector field type (#2304) (cherry picked from commit e34cdb6) --------- Co-authored-by: Carlos Delgado <[email protected]>
Thanks for looking into that @pquentin ! It's just been merged in elastic/elasticsearch#100348 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sparse_vector field support (added to Elasticsearch elastic/elasticsearch#98996) to mappings, and include it as usable in the docs for
text_expansionquery.