-
Notifications
You must be signed in to change notification settings - Fork 101
Added variants handling #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loving how we end up with something simple yet capturing all that is needed for strongly typed languages!
Added some comments to add a 3rd variant kind container
.
@@ -179,6 +200,8 @@ export class Interface extends BaseType { | |||
*/ | |||
attachedBehaviors?: string[] | |||
properties: Property[] | |||
/** Identify containers */ | |||
variants?: ExternalTag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be:
variants?: ExternalTag | |
variants?: Container |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once https://github.com/elastic/elastic-client-generator/pull/234/files#r602496498 has been fixed. This is beautiful!
This is good to go 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (still found a typo)
Awesome stuff, I'll add the @variants
annotations and additional model validations in a follow-up PR.
Co-authored-by: Sylvain Wallez <[email protected]>
As titled.
External variant example:
Internal variant example:
TODO:
Property
andto use the new variant utilities. (depends on Address feedback from Kibana #232)TokenFilter