Skip to content

Change replacement for PathHierarchyTokenizer to be optional #2349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

Anaethelion
Copy link
Contributor

As per the docs for Path hierarchy tokenizer the replacement field should be optional.

Copy link
Member

@JoshMock JoshMock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@Anaethelion Anaethelion merged commit e634a3a into main Nov 20, 2023
@Anaethelion Anaethelion deleted the fix_path_hierarchy_tokenizer branch November 20, 2023 10:41
github-actions bot pushed a commit that referenced this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants