Skip to content

Initial version of ES|QL query endpoint #2354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Nov 28, 2023
Merged

Initial version of ES|QL query endpoint #2354

merged 13 commits into from
Nov 28, 2023

Conversation

Anaethelion
Copy link
Contributor

Based on the following resources:

ES|QL REST API
EsqlQueryRequest.java
QueryPragmas.java

@Anaethelion Anaethelion requested review from a team and bpintea November 22, 2023 15:47
bpintea
bpintea reviewed Nov 23, 2023
View reviewed changes
Copy link

@bpintea bpintea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting this, @Anaethelion!
I've left some comments.

swallez
swallez reviewed Nov 23, 2023
View reviewed changes
swallez
swallez approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@swallez swallez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we need to decide what to do with Pragmas. Considering @bpintea's comment IMHO we should remove them from the API spec, but being conscious that if they exist, some people will use them even if not publicly documented.

@bpintea
Copy link

bpintea commented Nov 27, 2023

we need to decide what to do with Pragmas

I hope to provide an update on this today.

bpintea
bpintea approved these changes Nov 27, 2023
View reviewed changes
Copy link

@bpintea bpintea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the pragmas issue, it LGTM.

@github-actions GitHub Actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
esql.query 🟠 Missing type Missing type

You can validate these APIs yourself by using the make validate target.

@Anaethelion Anaethelion merged commit 747f812 into main Nov 28, 2023
@Anaethelion Anaethelion deleted the esql_query branch November 28, 2023 14:05
@pquentin pquentin mentioned this pull request Nov 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swallez swallez swallez approved these changes

@bpintea bpintea bpintea approved these changes

Assignees
No one assigned
Labels
specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Anaethelion @bpintea @swallez