Skip to content

Add optional query param in _field_caps to return only fields with value in index #2413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

piergm
Copy link
Member

@piergm piergm commented Feb 9, 2024

Updates the spec for the request object for all _field_caps endpoints.
In 8.13 we are adding a new optional query parameter include_empty_fields that defaults to true. If false empty fields are not included in the response. This change will not alter the _field_caps response schema.
elastic/elasticsearch#103651

@piergm piergm requested a review from a team as a code owner February 9, 2024 10:32
@piergm piergm self-assigned this Feb 9, 2024
Copy link
Contributor

@Anaethelion Anaethelion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

github-actions bot commented Feb 9, 2024

Following you can find the validation results for the API you have changed.

API Status Request Response
field_caps 🔴 51/52 43/52

You can validate this API yourself by using the make validate target.

Copy link
Contributor

@Anaethelion Anaethelion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@piergm piergm merged commit 88bcaaa into main Feb 12, 2024
@piergm piergm deleted the search/add-parameter-for-non-empty-fields-in_field_caps branch February 12, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants