Skip to content

Add inner_hits field to KnnQuery within search #2422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Conversation

Anaethelion
Copy link
Contributor

KnnQuery reuses the same InnerHits as NestedQuery. source

Fixes #2406

@swallez
Copy link
Member

swallez commented Feb 20, 2024

While we're in the knn area, it seems we don't have the knn query type in QueryContainer - https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-knn-query.html

@Anaethelion Anaethelion merged commit 6a1243d into main Feb 20, 2024
@Anaethelion Anaethelion deleted the add_knn_inner_hits branch February 20, 2024 14:23
github-actions bot pushed a commit that referenced this pull request Feb 20, 2024
Anaethelion added a commit that referenced this pull request Feb 20, 2024
(cherry picked from commit 6a1243d)

Co-authored-by: Laurent Saint-Félix <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KnnQuery missing the InnerHits field
2 participants