Skip to content

[Inference API] update path arguments #2430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Conversation

Anaethelion
Copy link
Contributor

This propagates the changes made in elastic/elasticsearch@5f32518

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
inference.delete_model Missing test Missing test
inference.get_model 🔴 1/1 0/1
inference.inference Missing test Missing test
inference.put_model Missing test Missing test

You can validate these APIs yourself by using the make validate target.

Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidkyle
Copy link
Member

Thank you @Anaethelion for doing this and updating the request classes

@Anaethelion Anaethelion merged commit d16a19a into main Feb 22, 2024
@Anaethelion Anaethelion deleted the update_inference_api branch February 22, 2024 14:10
github-actions bot pushed a commit that referenced this pull request Feb 22, 2024
* update path arguments for inference API

* prettify json spec files

(cherry picked from commit d16a19a)
Anaethelion added a commit that referenced this pull request Feb 22, 2024
* update path arguments for inference API

* prettify json spec files

(cherry picked from commit d16a19a)

Co-authored-by: Laurent Saint-Félix <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants