Skip to content

Define Pipeline._meta as optional #2436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 5, 2024
Merged

Define Pipeline._meta as optional #2436

merged 2 commits into from
Mar 5, 2024

Conversation

pgayvallet
Copy link
Contributor

Fix #2434
Follow-up of PR #2348

Define the _meta field of the Pipeline type as optional instead of required, to reflect the actual shape of the requests/responses using the type

@pgayvallet pgayvallet requested a review from JoshMock March 5, 2024 08:31
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ingest.delete_pipeline 🟢 11/11 11/11
ingest.geo_ip_stats ⚪ Missing test Missing test
ingest.get_pipeline 🔴 22/22 21/22
ingest.processor_grok 🟢 1/1 1/1
ingest.put_pipeline 🔴 33/42 40/42
ingest.simulate 🔴 4/7 6/7

You can validate these APIs yourself by using the make validate target.

pquentin
pquentin approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM. Looking at the title of the pull request that introduced it (#2348), this was always meant to be optional

@pquentin pquentin merged commit 0672f8f into main Mar 5, 2024
@pquentin pquentin deleted the issue-2434 branch March 5, 2024 10:41
github-actions bot pushed a commit that referenced this pull request Mar 5, 2024
@pgayvallet @pquentin @github-actions
Define Pipeline._meta as optional (#2436)
edcadf3 
* Define `Pipeline._meta` as optional

* Run make contrib

---------

Co-authored-by: Quentin Pradet <[email protected]>
(cherry picked from commit 0672f8f)
@github-actions github-actions bot mentioned this pull request Mar 5, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Mar 5, 2024
@pgayvallet @pquentin @github-actions
Define Pipeline._meta as optional (#2436)
8fdb28a 
* Define `Pipeline._meta` as optional

* Run make contrib

---------

Co-authored-by: Quentin Pradet <[email protected]>
(cherry picked from commit 0672f8f)
@github-actions github-actions bot mentioned this pull request Mar 5, 2024
Merged
@l-trotta l-trotta mentioned this pull request Dec 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pquentin pquentin pquentin approved these changes

@JoshMock JoshMock Awaiting requested review from JoshMock

Assignees
No one assigned
Labels
backport 8.12 backport 8.13 specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pipeline._meta should be optional
2 participants
@pgayvallet @pquentin