Skip to content

[ML] Change cohere rerank response format #2499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 10, 2024
Merged

[ML] Change cohere rerank response format #2499

merged 4 commits into from
Apr 10, 2024

Conversation

maxhniebergall
Copy link
Contributor

@maxhniebergall
renamed id to index
b217ecb
@maxhniebergall
Change rerank RankedDocument response format
bc6cc74
@maxhniebergall
Merge branch 'main' of https://github.com/elastic/elasticsearch-speci…
6ad93a1 
…fication into rerankRenameId

# Conflicts:
#	output/openapi/elasticsearch-serverless-openapi.json
#	output/typescript/types.ts
#	specification/inference/_types/Results.ts
pquentin
pquentin approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@github-actions GitHub Actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
inference.delete_model ⚪ Missing test Missing test
inference.get_model 🔴 0/1 0/1
inference.inference ⚪ Missing test Missing test
inference.put_model ⚪ Missing test Missing test

You can validate these APIs yourself by using the make validate target.

@maxhniebergall maxhniebergall merged commit d4f9261 into main Apr 10, 2024
@maxhniebergall maxhniebergall deleted the rerankRenameId branch April 10, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pquentin pquentin pquentin approved these changes

@jonathan-buttner jonathan-buttner jonathan-buttner approved these changes

Assignees
No one assigned
Labels
ml specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxhniebergall @pquentin @jonathan-buttner