Skip to content

Upgrade to checkout@v4 #2557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 17, 2024
Merged

Upgrade to checkout@v4 #2557

merged 3 commits into from
May 17, 2024

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented May 17, 2024

This reverts commit 44b9814.
@pquentin
Copy link
Member Author

I added a dummy file to trigger CI, which happened here: https://github.com/elastic/elasticsearch-specification/actions/runs/9123956086/job/25087262219. And the checkout worked, even though the dummy file broke validation itself.

@pquentin pquentin merged commit f96234e into main May 17, 2024
5 checks passed
@pquentin pquentin deleted the upgrade-checkout branch May 17, 2024 08:02
Copy link
Contributor

The backport to 7.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.17 7.17
# Navigate to the new working tree
cd .worktrees/backport-7.17
# Create a new branch
git switch --create backport-2557-to-7.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f96234e26b0ed2482580c4e9f09455a56b5f7347
# Push it to GitHub
git push --set-upstream origin backport-2557-to-7.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.17

Then, create a pull request where the base branch is 7.17 and the compare/head branch is backport-2557-to-7.17.

github-actions bot pushed a commit that referenced this pull request May 17, 2024
(cherry picked from commit f96234e)
github-actions bot pushed a commit that referenced this pull request May 17, 2024
(cherry picked from commit f96234e)
l-trotta pushed a commit that referenced this pull request May 17, 2024
(cherry picked from commit f96234e)

Co-authored-by: Quentin Pradet <[email protected]>
l-trotta pushed a commit that referenced this pull request May 17, 2024
(cherry picked from commit f96234e)

Co-authored-by: Quentin Pradet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants