Add IcuCollationProperty
#2599
Merged
Add IcuCollationProperty
#2599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flobernd
commented
Jun 5, 2024
| @@ -51,16 +51,16 @@ export class IcuFoldingTokenFilter extends TokenFilterBase { | |||
| export class IcuCollationTokenFilter extends TokenFilterBase { | |||
There was a problem hiding this comment.
Just noticed that the IcuCollationTokenFilter field names do not seem to be correct. Let`s fix them as well while we are on it...
flobernd
force-pushed
the
icu-collation-property
branch
from
bad97fa to
3f559d8
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Jun 5, 2024
* Add `IcuCollationProperty` * Fix `IcuCollationTokenFilter` field names * Reformat * Add `norms` and `index_options` * format --------- Co-authored-by: Laura Trotta <[email protected]> (cherry picked from commit 7b5e915)
flobernd
pushed a commit
that referenced
this pull request
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: elastic/elasticsearch-net#8212
Server code:
https://github.com/elastic/elasticsearch/blob/c5892a7044b51012e5680346c3bf7e03a70ce70d/plugins/analysis-icu/src/main/java/org/elasticsearch/plugin/analysis/icu/ICUCollationKeywordFieldMapper.java#L221