Add specification for delete roles #2683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pquentin
reviewed
Jul 10, 2024
Comment on lines
37
to
46
| errors?: { | ||
| /** | ||
| * The number of errors | ||
| */ | ||
| count: integer | ||
| /** | ||
| * Details about the errors, keyed by role name | ||
| */ | ||
| details: Dictionary<string, ErrorCause> | ||
| } |
There was a problem hiding this comment.
I believe you need a separate class for this
There was a problem hiding this comment.
Thanks! I've added a class to this PR so just waiting for it to be merged.
jfreden
force-pushed
the
add_spec_bulk_delete_roles
branch
from
fa31d38 to
3202112
Compare
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
pquentin
approved these changes
Jul 10, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jul 10, 2024
* Add specification for delete roles (cherry picked from commit 1b94182)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new spec for the bulk delete roles API added in 8.15 in elastic/elasticsearch#110383.