Skip to content

Java issues batch 7 #2704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 11, 2024
Merged

Java issues batch 7 #2704

merged 7 commits into from
Jul 11, 2024

Conversation

l-trotta
Copy link
Contributor

@l-trotta l-trotta commented Jul 10, 2024

  • 826: language in snowball token filter should be optional, server defaults to English. server code
  • 831: nested missing from geo distance sort. server code
  • 834: unhealthy_policies is optional in SlmIndicator, no hard proof found in the server code except that it can be an empty collection, but it's easily verifiable by calling GET _health_report in a new cloud instance.
  • 835: AllocationRecord was missing some fields. server code, docs.
  • 842: in TransformProgress, total_docs can be null, and if it is, docs_remaining and percent_complete are null too. server code

bonus validator finds:

  • stagnating_indices was missing from IlmIndicatorDetails server code
  • creating_replicas was missing from ShardsAvailabilityIndicatorDetails server code

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
cat.allocation 🔴 12/12 5/12
health_report 🔴 4/4 2/4
transform.get_transform_stats 🔴 34/34 33/34

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
cat.allocation 🔴 12/12 5/12
health_report 🔴 4/4 2/4
transform.get_transform_stats 🔴 34/34 33/34

You can validate these APIs yourself by using the make validate target.

/**
* Amount of shards that are scheduled to be moved elsewhere in the cluster or -1 other than desired balance allocator is used
*/
'shards.undesired'?: string | null
Copy link
Member

@flobernd flobernd Jul 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the linked server-code it seems like these properties are always present. Should we remove the optional modifier? IDEM for the other added fields.

Copy link
Contributor

@Anaethelion Anaethelion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only left a nit!

@@ -150,6 +150,7 @@ export class IlmIndicator extends BaseIndicator {
export class IlmIndicatorDetails {
ilm_status: LifecycleOperationMode
policies: long
stagnating_indices: long
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: stagnating_indices is returned as a size so it should be an integer.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
cat.allocation 🔴 12/12 2/12
health_report 🔴 4/4 3/4
transform.get_transform_stats 🔴 34/34 33/34

You can validate these APIs yourself by using the make validate target.

@l-trotta
Copy link
Contributor Author

I think I'll try to turn those dots green in another PRs, there's too many types missing

@l-trotta l-trotta merged commit 246b1a6 into main Jul 11, 2024
6 checks passed
@l-trotta l-trotta deleted the java-issues-batch-7 branch July 11, 2024 09:39
Copy link
Contributor

The backport to 8.14 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.14 8.14
# Navigate to the new working tree
cd .worktrees/backport-8.14
# Create a new branch
git switch --create backport-2704-to-8.14
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 246b1a6ccbcfc17ebdb6ca9737fe18e53c1efa46
# Push it to GitHub
git push --set-upstream origin backport-2704-to-8.14
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.14

Then, create a pull request where the base branch is 8.14 and the compare/head branch is backport-2704-to-8.14.

github-actions bot pushed a commit that referenced this pull request Jul 11, 2024
* snowball token language field optional (826)

* geo distance sort missing nested field (831)

* unhealthy policies nullable (834)

* missing properties from allocation record (835)

* nullable properties in transform progress (842)

* adding missing stagnating_indices field to ilm indicator

* fixing types, added creating_replicas

(cherry picked from commit 246b1a6)
l-trotta added a commit that referenced this pull request Jul 11, 2024
* snowball token language field optional (826)

* geo distance sort missing nested field (831)

* unhealthy policies nullable (834)

* missing properties from allocation record (835)

* nullable properties in transform progress (842)

* adding missing stagnating_indices field to ilm indicator

* fixing types, added creating_replicas

(cherry picked from commit 246b1a6)

Co-authored-by: Laura Trotta <[email protected]>
l-trotta added a commit that referenced this pull request Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants