-
Notifications
You must be signed in to change notification settings - Fork 102
Java issues batch 7 #2704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java issues batch 7 #2704
Conversation
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
/** | ||
* Amount of shards that are scheduled to be moved elsewhere in the cluster or -1 other than desired balance allocator is used | ||
*/ | ||
'shards.undesired'?: string | null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the linked server-code it seems like these properties are always present. Should we remove the optional modifier? IDEM for the other added fields.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only left a nit!
@@ -150,6 +150,7 @@ export class IlmIndicator extends BaseIndicator { | |||
export class IlmIndicatorDetails { | |||
ilm_status: LifecycleOperationMode | |||
policies: long | |||
stagnating_indices: long |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: stagnating_indices
is returned as a size so it should be an integer.
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
I think I'll try to turn those dots green in another PRs, there's too many types missing |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.14 8.14
# Navigate to the new working tree
cd .worktrees/backport-8.14
# Create a new branch
git switch --create backport-2704-to-8.14
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 246b1a6ccbcfc17ebdb6ca9737fe18e53c1efa46
# Push it to GitHub
git push --set-upstream origin backport-2704-to-8.14
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.14 Then, create a pull request where the |
* snowball token language field optional (826) * geo distance sort missing nested field (831) * unhealthy policies nullable (834) * missing properties from allocation record (835) * nullable properties in transform progress (842) * adding missing stagnating_indices field to ilm indicator * fixing types, added creating_replicas (cherry picked from commit 246b1a6)
* snowball token language field optional (826) * geo distance sort missing nested field (831) * unhealthy policies nullable (834) * missing properties from allocation record (835) * nullable properties in transform progress (842) * adding missing stagnating_indices field to ilm indicator * fixing types, added creating_replicas (cherry picked from commit 246b1a6) Co-authored-by: Laura Trotta <[email protected]>
language
in snowball token filter should be optional, server defaults to English. server codenested
missing from geo distance sort. server codeunhealthy_policies
is optional in SlmIndicator, no hard proof found in the server code except that it can be an empty collection, but it's easily verifiable by callingGET _health_report
in a new cloud instance.total_docs
can be null, and if it is,docs_remaining
andpercent_complete
are null too. server codebonus validator finds:
stagnating_indices
was missing from IlmIndicatorDetails server codecreating_replicas
was missing from ShardsAvailabilityIndicatorDetails server code