[Proposal] Transform script into a container #2708

Anaethelion · 2024-07-11T12:57:19Z

@shortcut_property on InlineScript is unreachable from the union.
From the server code, Script could benefit from being a container instead.

github-actions · 2024-07-11T13:00:50Z

Following you can find the validation results for the APIs you have changed.

API	Status	Request	Response
`query_rules.delete_rule`	🟢	6/6	6/6
`query_rules.delete_ruleset`	🟢	7/7	7/7
`query_rules.get_rule`	🟢	5/5	5/5
`query_rules.get_ruleset`	🟢	8/8	8/8
`query_rules.list_rulesets`	🟢	7/7	7/7
`query_rules.put_rule`	🟢	7/7	7/7
`query_rules.put_ruleset`	🟢	10/10	10/10
`scripts_painless_execute`	🔴	3/4	4/4
`search_application.delete_behavioral_analytics`	🟢	3/3	3/3
`search_application.delete`	🟢	7/7	7/7
`search_application.get_behavioral_analytics`	🔴	2/5	5/5
`search_application.get`	🔴	10/10	6/10
`search_application.list`	🔴	7/7	2/7
`search_application.post_behavioral_analytics_event`	🟠	Missing type	Missing type
`search_application.put_behavioral_analytics`	🟢	3/3	3/3
`search_application.put`	🔴	0/10	10/10
`search_application.render_query`	🟠	Missing type	Missing type
`search_application.search`	🟢	16/16	16/16
`security.activate_user_profile`	🟢	9/9	9/9
`security.authenticate`	🟢	30/30	30/30
`security.bulk_delete_role`	🟢	1/1	1/1
`security.bulk_put_role`	🟢	1/1	1/1
`security.bulk_update_api_keys`	🟠	Missing type	Missing type
`security.change_password`	🟢	9/9	9/9
`security.clear_api_key_cache`	🟢	13/13	13/13
`security.clear_cached_privileges`	🟢	3/3	3/3
`security.clear_cached_realms`	🟢	1/1	1/1
`security.clear_cached_roles`	🟢	2/2	2/2
`security.clear_cached_service_tokens`	🟢	4/4	4/4
`security.create_api_key`	🔴	67/69	60/60
`security.create_cross_cluster_api_key`	🟠	Missing type	Missing type
`security.create_service_token`	🟢	3/3	3/3
`security.delete_privileges`	🟢	6/6	6/6
`security.delete_role_mapping`	🟢	9/9	9/9
`security.delete_role`	🟢	8/8	8/8
`security.delete_service_token`	⚪	Missing test	Missing test
`security.delete_user`	🟢	9/9	9/9
`security.disable_user_profile`	🟢	1/1	1/1
`security.disable_user`	🟢	3/3	3/3
`security.enable_user_profile`	🟢	1/1	1/1
`security.enable_user`	🟢	4/4	4/4
`security.enroll_kibana`	⚪	Missing test	Missing test
`security.enroll_node`	⚪	Missing test	Missing test
`security.get_api_key`	🔴	38/38	15/38
`security.get_builtin_privileges`	🔴	2/2	1/2
`security.get_privileges`	🟢	12/12	12/12
`security.get_role_mapping`	🔴	18/18	10/18
`security.get_role`	🔴	24/24	21/24
`security.get_service_accounts`	⚪	Missing test	Missing test
`security.get_service_credentials`	🟢	1/1	1/1
`security.get_settings`	🟠	Missing type	Missing type
`security.get_token`	🟢	25/25	24/24
`security.get_user_privileges`	🔴	8/8	7/8
`security.get_user_profile`	🟢	8/8	8/8
`security.get_user`	🟢	25/25	25/25
`security.grant_api_key`	🟢	7/7	7/7
`security.has_privileges_user_profile`	🟢	3/3	3/3
`security.has_privileges`	🟢	24/24	24/24
`security.invalidate_api_key`	🟢	12/12	12/12
`security.invalidate_token`	🟢	11/11	11/11
`security.oidc_authenticate`	🟠	Missing type	Missing type
`security.oidc_logout`	🟠	Missing type	Missing type
`security.oidc_prepare_authentication`	🟠	Missing type	Missing type
`security.put_privileges`	🟢	10/10	10/10
`security.put_role_mapping`	🔴	2/11	11/11
`security.put_role`	🔴	39/40	39/39
`security.put_user`	🟢	49/49	48/48
`security.query_api_keys`	🔴	14/14	1/14
`security.query_role`	🟢	2/2	2/2
`security.query_user`	🟢	4/4	4/4
`security.saml_authenticate`	⚪	Missing test	Missing test
`security.saml_complete_logout`	⚪	Missing test	Missing test
`security.saml_invalidate`	⚪	Missing test	Missing test
`security.saml_logout`	⚪	Missing test	Missing test
`security.saml_prepare_authentication`	⚪	Missing test	Missing test
`security.saml_service_provider_metadata`	⚪	Missing test	Missing test
`security.suggest_user_profiles`	🟢	1/1	1/1
`security.update_api_key`	🟢	5/5	5/5
`security.update_cross_cluster_api_key`	🟠	Missing type	Missing type
`security.update_settings`	🟠	Missing type	Missing type
`security.update_user_profile_data`	🟢	1/1	1/1

You can validate these APIs yourself by using the make validate target.

swallez

If we're going that route, I would go as far as not making it a container: lang and options only apply to inline script, so it's weird to allow id xor source while having these container properties that will cause a server-side failure if set for the wrong variant.

Anaethelion · 2024-07-11T14:57:04Z

I'm OK with merging everything in the same interface.
pinging @l-trotta @flobernd for visibility!

flobernd · 2024-07-11T15:01:23Z

I like the container solution a little bit better over the single interface, but no strong preference here. Fine with a single interface as well. This is definitely better than what we currently have.

github-actions · 2024-07-11T15:27:28Z

Following you can find the validation results for the APIs you have changed.

API	Status	Request	Response
`query_rules.delete_rule`	🟢	6/6	6/6
`query_rules.delete_ruleset`	🟢	7/7	7/7
`query_rules.get_rule`	🟢	5/5	5/5
`query_rules.get_ruleset`	🟢	8/8	8/8
`query_rules.list_rulesets`	🟢	7/7	7/7
`query_rules.put_rule`	🟢	7/7	7/7
`query_rules.put_ruleset`	🟢	10/10	10/10
`scripts_painless_execute`	🔴	3/4	4/4
`search_application.delete_behavioral_analytics`	🟢	3/3	3/3
`search_application.delete`	🟢	7/7	7/7
`search_application.get_behavioral_analytics`	🔴	2/5	5/5
`search_application.get`	🔴	10/10	6/10
`search_application.list`	🔴	7/7	2/7
`search_application.post_behavioral_analytics_event`	🟠	Missing type	Missing type
`search_application.put_behavioral_analytics`	🟢	3/3	3/3
`search_application.put`	🔴	0/10	10/10
`search_application.render_query`	🟠	Missing type	Missing type
`search_application.search`	🟢	16/16	16/16
`security.activate_user_profile`	🟢	9/9	9/9
`security.authenticate`	🟢	30/30	30/30
`security.bulk_delete_role`	🟢	1/1	1/1
`security.bulk_put_role`	🟢	1/1	1/1
`security.bulk_update_api_keys`	🟠	Missing type	Missing type
`security.change_password`	🟢	9/9	9/9
`security.clear_api_key_cache`	🟢	13/13	13/13
`security.clear_cached_privileges`	🟢	3/3	3/3
`security.clear_cached_realms`	🟢	1/1	1/1
`security.clear_cached_roles`	🟢	2/2	2/2
`security.clear_cached_service_tokens`	🟢	4/4	4/4
`security.create_api_key`	🔴	67/69	60/60
`security.create_cross_cluster_api_key`	🟠	Missing type	Missing type
`security.create_service_token`	🟢	3/3	3/3
`security.delete_privileges`	🟢	6/6	6/6
`security.delete_role_mapping`	🟢	9/9	9/9
`security.delete_role`	🟢	8/8	8/8
`security.delete_service_token`	⚪	Missing test	Missing test
`security.delete_user`	🟢	9/9	9/9
`security.disable_user_profile`	🟢	1/1	1/1
`security.disable_user`	🟢	3/3	3/3
`security.enable_user_profile`	🟢	1/1	1/1
`security.enable_user`	🟢	4/4	4/4
`security.enroll_kibana`	⚪	Missing test	Missing test
`security.enroll_node`	⚪	Missing test	Missing test
`security.get_api_key`	🔴	38/38	15/38
`security.get_builtin_privileges`	🔴	2/2	1/2
`security.get_privileges`	🟢	12/12	12/12
`security.get_role_mapping`	🔴	18/18	10/18
`security.get_role`	🔴	24/24	21/24
`security.get_service_accounts`	⚪	Missing test	Missing test
`security.get_service_credentials`	🟢	1/1	1/1
`security.get_settings`	🟠	Missing type	Missing type
`security.get_token`	🟢	25/25	24/24
`security.get_user_privileges`	🔴	8/8	7/8
`security.get_user_profile`	🟢	8/8	8/8
`security.get_user`	🟢	25/25	25/25
`security.grant_api_key`	🟢	7/7	7/7
`security.has_privileges_user_profile`	🟢	3/3	3/3
`security.has_privileges`	🟢	24/24	24/24
`security.invalidate_api_key`	🟢	12/12	12/12
`security.invalidate_token`	🟢	11/11	11/11
`security.oidc_authenticate`	🟠	Missing type	Missing type
`security.oidc_logout`	🟠	Missing type	Missing type
`security.oidc_prepare_authentication`	🟠	Missing type	Missing type
`security.put_privileges`	🟢	10/10	10/10
`security.put_role_mapping`	🔴	2/11	11/11
`security.put_role`	🔴	39/40	39/39
`security.put_user`	🟢	49/49	48/48
`security.query_api_keys`	🔴	14/14	1/14
`security.query_role`	🟢	2/2	2/2
`security.query_user`	🟢	4/4	4/4
`security.saml_authenticate`	⚪	Missing test	Missing test
`security.saml_complete_logout`	⚪	Missing test	Missing test
`security.saml_invalidate`	⚪	Missing test	Missing test
`security.saml_logout`	⚪	Missing test	Missing test
`security.saml_prepare_authentication`	⚪	Missing test	Missing test
`security.saml_service_provider_metadata`	⚪	Missing test	Missing test
`security.suggest_user_profiles`	🟢	1/1	1/1
`security.update_api_key`	🟢	5/5	5/5
`security.update_cross_cluster_api_key`	🟠	Missing type	Missing type
`security.update_settings`	🟠	Missing type	Missing type
`security.update_user_profile_data`	🟢	1/1	1/1

You can validate these APIs yourself by using the make validate target.

l-trotta · 2024-07-11T15:36:06Z

RoleTemplateInlineScript has duplicate fields from ScriptBase, we should remove lang and options

github-actions · 2024-07-11T15:44:42Z

Following you can find the validation results for the APIs you have changed.

API	Status	Request	Response
`query_rules.delete_rule`	🟢	6/6	6/6
`query_rules.delete_ruleset`	🟢	7/7	7/7
`query_rules.get_rule`	🟢	5/5	5/5
`query_rules.get_ruleset`	🟢	8/8	8/8
`query_rules.list_rulesets`	🟢	7/7	7/7
`query_rules.put_rule`	🟢	7/7	7/7
`query_rules.put_ruleset`	🟢	10/10	10/10
`scripts_painless_execute`	🔴	3/4	4/4
`search_application.delete_behavioral_analytics`	🟢	3/3	3/3
`search_application.delete`	🟢	7/7	7/7
`search_application.get_behavioral_analytics`	🔴	2/5	5/5
`search_application.get`	🔴	10/10	6/10
`search_application.list`	🔴	7/7	2/7
`search_application.post_behavioral_analytics_event`	🟠	Missing type	Missing type
`search_application.put_behavioral_analytics`	🟢	3/3	3/3
`search_application.put`	🔴	0/10	10/10
`search_application.render_query`	🟠	Missing type	Missing type
`search_application.search`	🟢	16/16	16/16
`security.activate_user_profile`	🟢	9/9	9/9
`security.authenticate`	🟢	30/30	30/30
`security.bulk_delete_role`	🟢	1/1	1/1
`security.bulk_put_role`	🟢	1/1	1/1
`security.bulk_update_api_keys`	🟠	Missing type	Missing type
`security.change_password`	🟢	9/9	9/9
`security.clear_api_key_cache`	🟢	13/13	13/13
`security.clear_cached_privileges`	🟢	3/3	3/3
`security.clear_cached_realms`	🟢	1/1	1/1
`security.clear_cached_roles`	🟢	2/2	2/2
`security.clear_cached_service_tokens`	🟢	4/4	4/4
`security.create_api_key`	🔴	67/69	60/60
`security.create_cross_cluster_api_key`	🟠	Missing type	Missing type
`security.create_service_token`	🟢	3/3	3/3
`security.delete_privileges`	🟢	6/6	6/6
`security.delete_role_mapping`	🟢	9/9	9/9
`security.delete_role`	🟢	8/8	8/8
`security.delete_service_token`	⚪	Missing test	Missing test
`security.delete_user`	🟢	9/9	9/9
`security.disable_user_profile`	🟢	1/1	1/1
`security.disable_user`	🟢	3/3	3/3
`security.enable_user_profile`	🟢	1/1	1/1
`security.enable_user`	🟢	4/4	4/4
`security.enroll_kibana`	⚪	Missing test	Missing test
`security.enroll_node`	⚪	Missing test	Missing test
`security.get_api_key`	🔴	38/38	15/38
`security.get_builtin_privileges`	🔴	2/2	1/2
`security.get_privileges`	🟢	12/12	12/12
`security.get_role_mapping`	🔴	18/18	10/18
`security.get_role`	🔴	24/24	21/24
`security.get_service_accounts`	⚪	Missing test	Missing test
`security.get_service_credentials`	🟢	1/1	1/1
`security.get_settings`	🟠	Missing type	Missing type
`security.get_token`	🟢	25/25	24/24
`security.get_user_privileges`	🔴	8/8	7/8
`security.get_user_profile`	🟢	8/8	8/8
`security.get_user`	🟢	25/25	25/25
`security.grant_api_key`	🟢	7/7	7/7
`security.has_privileges_user_profile`	🟢	3/3	3/3
`security.has_privileges`	🟢	24/24	24/24
`security.invalidate_api_key`	🟢	12/12	12/12
`security.invalidate_token`	🟢	11/11	11/11
`security.oidc_authenticate`	🟠	Missing type	Missing type
`security.oidc_logout`	🟠	Missing type	Missing type
`security.oidc_prepare_authentication`	🟠	Missing type	Missing type
`security.put_privileges`	🟢	10/10	10/10
`security.put_role_mapping`	🔴	2/11	11/11
`security.put_role`	🔴	39/40	39/39
`security.put_user`	🟢	49/49	48/48
`security.query_api_keys`	🔴	14/14	1/14
`security.query_role`	🟢	2/2	2/2
`security.query_user`	🟢	4/4	4/4
`security.saml_authenticate`	⚪	Missing test	Missing test
`security.saml_complete_logout`	⚪	Missing test	Missing test
`security.saml_invalidate`	⚪	Missing test	Missing test
`security.saml_logout`	⚪	Missing test	Missing test
`security.saml_prepare_authentication`	⚪	Missing test	Missing test
`security.saml_service_provider_metadata`	⚪	Missing test	Missing test
`security.suggest_user_profiles`	🟢	1/1	1/1
`security.update_api_key`	🟢	5/5	5/5
`security.update_cross_cluster_api_key`	🟠	Missing type	Missing type
`security.update_settings`	🟠	Missing type	Missing type
`security.update_user_profile_data`	🟢	1/1	1/1

You can validate these APIs yourself by using the make validate target.

l-trotta · 2024-07-11T16:05:34Z

LGTM but it breaks deserialization for RoleTemplateScript the java client, if we could wait until I fix it before merging this

swallez

LGTM.

github-actions · 2024-07-12T10:54:11Z

Following you can find the validation results for the APIs you have changed.

API	Status	Request	Response
`query_rules.delete_rule`	🟢	6/6	6/6
`query_rules.delete_ruleset`	🟢	7/7	7/7
`query_rules.get_rule`	🟢	5/5	5/5
`query_rules.get_ruleset`	🟢	8/8	8/8
`query_rules.list_rulesets`	🟢	7/7	7/7
`query_rules.put_rule`	🟢	7/7	7/7
`query_rules.put_ruleset`	🟢	10/10	10/10
`scripts_painless_execute`	🔴	3/4	4/4
`search_application.delete_behavioral_analytics`	🟢	3/3	3/3
`search_application.delete`	🟢	7/7	7/7
`search_application.get_behavioral_analytics`	🔴	2/5	5/5
`search_application.get`	🔴	10/10	6/10
`search_application.list`	🔴	7/7	2/7
`search_application.post_behavioral_analytics_event`	🟠	Missing type	Missing type
`search_application.put_behavioral_analytics`	🟢	3/3	3/3
`search_application.put`	🔴	0/10	10/10
`search_application.render_query`	🟠	Missing type	Missing type
`search_application.search`	🟢	16/16	16/16
`security.activate_user_profile`	🟢	9/9	9/9
`security.authenticate`	🟢	30/30	30/30
`security.bulk_delete_role`	🟢	1/1	1/1
`security.bulk_put_role`	🟢	1/1	1/1
`security.bulk_update_api_keys`	🟠	Missing type	Missing type
`security.change_password`	🟢	9/9	9/9
`security.clear_api_key_cache`	🟢	13/13	13/13
`security.clear_cached_privileges`	🟢	3/3	3/3
`security.clear_cached_realms`	🟢	1/1	1/1
`security.clear_cached_roles`	🟢	2/2	2/2
`security.clear_cached_service_tokens`	🟢	4/4	4/4
`security.create_api_key`	🔴	67/69	60/60
`security.create_cross_cluster_api_key`	🟠	Missing type	Missing type
`security.create_service_token`	🟢	3/3	3/3
`security.delete_privileges`	🟢	6/6	6/6
`security.delete_role_mapping`	🟢	9/9	9/9
`security.delete_role`	🟢	8/8	8/8
`security.delete_service_token`	⚪	Missing test	Missing test
`security.delete_user`	🟢	9/9	9/9
`security.disable_user_profile`	🟢	1/1	1/1
`security.disable_user`	🟢	3/3	3/3
`security.enable_user_profile`	🟢	1/1	1/1
`security.enable_user`	🟢	4/4	4/4
`security.enroll_kibana`	⚪	Missing test	Missing test
`security.enroll_node`	⚪	Missing test	Missing test
`security.get_api_key`	🔴	38/38	15/38
`security.get_builtin_privileges`	🔴	2/2	1/2
`security.get_privileges`	🟢	12/12	12/12
`security.get_role_mapping`	🔴	18/18	10/18
`security.get_role`	🔴	24/24	21/24
`security.get_service_accounts`	⚪	Missing test	Missing test
`security.get_service_credentials`	🟢	1/1	1/1
`security.get_settings`	🟠	Missing type	Missing type
`security.get_token`	🟢	25/25	24/24
`security.get_user_privileges`	🔴	8/8	7/8
`security.get_user_profile`	🟢	8/8	8/8
`security.get_user`	🟢	25/25	25/25
`security.grant_api_key`	🟢	7/7	7/7
`security.has_privileges_user_profile`	🟢	3/3	3/3
`security.has_privileges`	🟢	24/24	24/24
`security.invalidate_api_key`	🟢	12/12	12/12
`security.invalidate_token`	🟢	11/11	11/11
`security.oidc_authenticate`	🟠	Missing type	Missing type
`security.oidc_logout`	🟠	Missing type	Missing type
`security.oidc_prepare_authentication`	🟠	Missing type	Missing type
`security.put_privileges`	🟢	10/10	10/10
`security.put_role_mapping`	🔴	2/11	11/11
`security.put_role`	🔴	39/40	39/39
`security.put_user`	🟢	49/49	48/48
`security.query_api_keys`	🔴	14/14	1/14
`security.query_role`	🟢	2/2	2/2
`security.query_user`	🟢	4/4	4/4
`security.saml_authenticate`	⚪	Missing test	Missing test
`security.saml_complete_logout`	⚪	Missing test	Missing test
`security.saml_invalidate`	⚪	Missing test	Missing test
`security.saml_logout`	⚪	Missing test	Missing test
`security.saml_prepare_authentication`	⚪	Missing test	Missing test
`security.saml_service_provider_metadata`	⚪	Missing test	Missing test
`security.suggest_user_profiles`	🟢	1/1	1/1
`security.update_api_key`	🟢	5/5	5/5
`security.update_cross_cluster_api_key`	🟠	Missing type	Missing type
`security.update_settings`	🟠	Missing type	Missing type
`security.update_user_profile_data`	🟢	1/1	1/1

You can validate these APIs yourself by using the make validate target.

github-actions · 2024-07-12T11:09:29Z

Following you can find the validation results for the APIs you have changed.

API	Status	Request	Response
`query_rules.delete_rule`	🟢	6/6	6/6
`query_rules.delete_ruleset`	🟢	7/7	7/7
`query_rules.get_rule`	🟢	5/5	5/5
`query_rules.get_ruleset`	🟢	8/8	8/8
`query_rules.list_rulesets`	🟢	7/7	7/7
`query_rules.put_rule`	🟢	7/7	7/7
`query_rules.put_ruleset`	🟢	10/10	10/10
`scripts_painless_execute`	🔴	3/4	4/4
`search_application.delete_behavioral_analytics`	🟢	3/3	3/3
`search_application.delete`	🟢	7/7	7/7
`search_application.get_behavioral_analytics`	🔴	2/5	5/5
`search_application.get`	🔴	10/10	6/10
`search_application.list`	🔴	7/7	2/7
`search_application.post_behavioral_analytics_event`	🟠	Missing type	Missing type
`search_application.put_behavioral_analytics`	🟢	3/3	3/3
`search_application.put`	🔴	0/10	10/10
`search_application.render_query`	🟠	Missing type	Missing type
`search_application.search`	🟢	16/16	16/16
`security.activate_user_profile`	🟢	9/9	9/9
`security.authenticate`	🟢	30/30	30/30
`security.bulk_delete_role`	🟢	1/1	1/1
`security.bulk_put_role`	🟢	1/1	1/1
`security.bulk_update_api_keys`	🟠	Missing type	Missing type
`security.change_password`	🟢	9/9	9/9
`security.clear_api_key_cache`	🟢	13/13	13/13
`security.clear_cached_privileges`	🟢	3/3	3/3
`security.clear_cached_realms`	🟢	1/1	1/1
`security.clear_cached_roles`	🟢	2/2	2/2
`security.clear_cached_service_tokens`	🟢	4/4	4/4
`security.create_api_key`	🔴	67/69	60/60
`security.create_cross_cluster_api_key`	🟠	Missing type	Missing type
`security.create_service_token`	🟢	3/3	3/3
`security.delete_privileges`	🟢	6/6	6/6
`security.delete_role_mapping`	🟢	9/9	9/9
`security.delete_role`	🟢	8/8	8/8
`security.delete_service_token`	⚪	Missing test	Missing test
`security.delete_user`	🟢	9/9	9/9
`security.disable_user_profile`	🟢	1/1	1/1
`security.disable_user`	🟢	3/3	3/3
`security.enable_user_profile`	🟢	1/1	1/1
`security.enable_user`	🟢	4/4	4/4
`security.enroll_kibana`	⚪	Missing test	Missing test
`security.enroll_node`	⚪	Missing test	Missing test
`security.get_api_key`	🔴	38/38	15/38
`security.get_builtin_privileges`	🔴	2/2	1/2
`security.get_privileges`	🟢	12/12	12/12
`security.get_role_mapping`	🔴	18/18	10/18
`security.get_role`	🔴	24/24	21/24
`security.get_service_accounts`	⚪	Missing test	Missing test
`security.get_service_credentials`	🟢	1/1	1/1
`security.get_settings`	🟠	Missing type	Missing type
`security.get_token`	🟢	25/25	24/24
`security.get_user_privileges`	🔴	8/8	7/8
`security.get_user_profile`	🟢	8/8	8/8
`security.get_user`	🟢	25/25	25/25
`security.grant_api_key`	🟢	7/7	7/7
`security.has_privileges_user_profile`	🟢	3/3	3/3
`security.has_privileges`	🟢	24/24	24/24
`security.invalidate_api_key`	🟢	12/12	12/12
`security.invalidate_token`	🟢	11/11	11/11
`security.oidc_authenticate`	🟠	Missing type	Missing type
`security.oidc_logout`	🟠	Missing type	Missing type
`security.oidc_prepare_authentication`	🟠	Missing type	Missing type
`security.put_privileges`	🟢	10/10	10/10
`security.put_role_mapping`	🔴	2/11	11/11
`security.put_role`	🔴	39/40	39/39
`security.put_user`	🟢	49/49	48/48
`security.query_api_keys`	🔴	14/14	1/14
`security.query_role`	🟢	2/2	2/2
`security.query_user`	🟢	4/4	4/4
`security.saml_authenticate`	⚪	Missing test	Missing test
`security.saml_complete_logout`	⚪	Missing test	Missing test
`security.saml_invalidate`	⚪	Missing test	Missing test
`security.saml_logout`	⚪	Missing test	Missing test
`security.saml_prepare_authentication`	⚪	Missing test	Missing test
`security.saml_service_provider_metadata`	⚪	Missing test	Missing test
`security.suggest_user_profiles`	🟢	1/1	1/1
`security.update_api_key`	🟢	5/5	5/5
`security.update_cross_cluster_api_key`	🟠	Missing type	Missing type
`security.update_settings`	🟠	Missing type	Missing type
`security.update_user_profile_data`	🟢	1/1	1/1

You can validate these APIs yourself by using the make validate target.

github-actions · 2024-07-12T11:20:22Z

The backport to 8.15 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.15 8.15
# Navigate to the new working tree
cd .worktrees/backport-8.15
# Create a new branch
git switch --create backport-2708-to-8.15
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 90fe7e26253312b8efb4cad3fcb5c49e02bb325d
# Push it to GitHub
git push --set-upstream origin backport-2708-to-8.15
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.15

Then, create a pull request where the base branch is 8.15 and the compare/head branch is backport-2708-to-8.15.

* transform script union to a container variant * Remove unused imports * refresh outputs * remove wrongly added empty files * merge script into a standard class * add output * remove duplicated fields * add newly generated output * simplify RoleTemplateScript to reflect Script changes * add newly generated output * make source option in RoleTemplateScript (cherry picked from commit 90fe7e2)

Anaethelion added 4 commits July 11, 2024 11:19

transform script union to a container variant

7ee1de5

Remove unused imports

b5a87d5

refresh outputs

2b593b8

remove wrongly added empty files

2017032

github-actions bot added the specification label Jul 11, 2024

swallez reviewed Jul 11, 2024

View reviewed changes

Anaethelion added 2 commits July 11, 2024 17:23

merge script into a standard class

659e03c

add output

7c0080a

Anaethelion marked this pull request as ready for review July 11, 2024 15:29

Anaethelion added 2 commits July 11, 2024 17:40

remove duplicated fields

cdad65d

add newly generated output

8ea75ba

swallez approved these changes Jul 11, 2024

View reviewed changes

Anaethelion added 2 commits July 12, 2024 12:50

simplify RoleTemplateScript to reflect Script changes

3088da6

add newly generated output

07e570a

flobernd approved these changes Jul 12, 2024

View reviewed changes

make source option in RoleTemplateScript

bbf6e84

l-trotta approved these changes Jul 12, 2024

View reviewed changes

Anaethelion added the backport 8.15 label Jul 12, 2024

Anaethelion merged commit 90fe7e2 into main Jul 12, 2024
7 checks passed

Anaethelion deleted the lsf/script_container branch July 12, 2024 11:19

Anaethelion mentioned this pull request Jul 12, 2024

[Backport 8.15] Transform script into a container (#2708) #2712

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Proposal] Transform script into a container #2708

[Proposal] Transform script into a container #2708

Uh oh!

Anaethelion commented Jul 11, 2024

Uh oh!

github-actions bot commented Jul 11, 2024

Uh oh!

swallez left a comment

Uh oh!

Anaethelion commented Jul 11, 2024

Uh oh!

flobernd commented Jul 11, 2024

Uh oh!

github-actions bot commented Jul 11, 2024

Uh oh!

l-trotta commented Jul 11, 2024

Uh oh!

github-actions bot commented Jul 11, 2024

Uh oh!

l-trotta commented Jul 11, 2024

Uh oh!

swallez left a comment

Uh oh!

github-actions bot commented Jul 12, 2024

Uh oh!

github-actions bot commented Jul 12, 2024

Uh oh!

Uh oh!

github-actions bot commented Jul 12, 2024

Uh oh!

Uh oh!

[Proposal] Transform script into a container #2708

[Proposal] Transform script into a container #2708

Uh oh!

Conversation

Anaethelion commented Jul 11, 2024

Uh oh!

github-actions bot commented Jul 11, 2024

Uh oh!

swallez left a comment

Choose a reason for hiding this comment

Uh oh!

Anaethelion commented Jul 11, 2024

Uh oh!

flobernd commented Jul 11, 2024

Uh oh!

github-actions bot commented Jul 11, 2024

Uh oh!

l-trotta commented Jul 11, 2024

Uh oh!

github-actions bot commented Jul 11, 2024

Uh oh!

l-trotta commented Jul 11, 2024

Uh oh!

swallez left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jul 12, 2024

Uh oh!

github-actions bot commented Jul 12, 2024

Uh oh!

Uh oh!

github-actions bot commented Jul 12, 2024

Uh oh!

Uh oh!