Skip to content

Mapping ILM phases #2737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 1, 2024
Merged

Mapping ILM phases #2737

merged 3 commits into from
Aug 1, 2024

Conversation

l-trotta
Copy link
Contributor

@l-trotta l-trotta commented Jul 24, 2024

fixes #2727

@l-trotta l-trotta marked this pull request as draft July 24, 2024 16:16
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ilm.delete_lifecycle 🟢 2/2 2/2
ilm.explain_lifecycle 🟢 5/5 5/5
ilm.get_lifecycle 🔴 8/8 0/8
ilm.get_status 🟢 4/4 4/4
ilm.migrate_to_data_tiers Missing test Missing test
ilm.move_to_step Missing test Missing test
ilm.put_lifecycle 🔴 2/6 6/6
ilm.remove_policy 🟢 5/5 5/5
ilm.retry Missing test Missing test
ilm.start Missing test Missing test
ilm.stop 🟢 4/4 4/4

You can validate these APIs yourself by using the make validate target.

@l-trotta
Copy link
Contributor Author

The validator is complaining about the missing action "Freeze", but that was removed in 8.0 and should be removed from the tests.

@l-trotta l-trotta marked this pull request as ready for review July 25, 2024 13:26
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ilm.delete_lifecycle 🟢 2/2 2/2
ilm.explain_lifecycle 🟢 5/5 5/5
ilm.get_lifecycle 🔴 8/8 0/8
ilm.get_status 🟢 4/4 4/4
ilm.migrate_to_data_tiers Missing test Missing test
ilm.move_to_step Missing test Missing test
ilm.put_lifecycle 🔴 2/6 6/6
ilm.remove_policy 🟢 5/5 5/5
ilm.retry Missing test Missing test
ilm.start Missing test Missing test
ilm.stop 🟢 4/4 4/4

You can validate these APIs yourself by using the make validate target.

@l-trotta l-trotta merged commit 1b736c6 into main Aug 1, 2024
7 checks passed
@l-trotta l-trotta deleted the mapping-ilm-phases branch August 1, 2024 07:28
Copy link
Contributor

github-actions bot commented Aug 1, 2024

The backport to 8.15 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.15 8.15
# Navigate to the new working tree
cd .worktrees/backport-8.15
# Create a new branch
git switch --create backport-2737-to-8.15
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1b736c6ad35772654162f5731c2bb6b4614fae85
# Push it to GitHub
git push --set-upstream origin backport-2737-to-8.15
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.15

Then, create a pull request where the base branch is 8.15 and the compare/head branch is backport-2737-to-8.15.

l-trotta added a commit that referenced this pull request Aug 1, 2024
* adding action types

* order

* no container
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ILM Phase types are missing properties
2 participants