Skip to content

Mark role APIs serverless public #2785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 10, 2024
Merged

Mark role APIs serverless public #2785

merged 5 commits into from
Oct 10, 2024

Conversation

n1v0lg
Copy link
Contributor

@n1v0lg n1v0lg commented Aug 13, 2024 •
edited
Loading

Marks relevant role APIs as public in Serverless.

Resolves: ES-7833

@n1v0lg n1v0lg self-assigned this Aug 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
security.delete_role 🟢 8/8 8/8
security.get_builtin_privileges 🔴 2/2 1/2
security.get_role 🔴 24/24 21/24
security.put_role 🔴 38/39 38/38

You can validate these APIs yourself by using the make validate target.

@github-actions GitHub Actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
security.delete_role 🟢 8/8 8/8
security.get_builtin_privileges 🔴 2/2 1/2
security.get_role 🔴 24/24 21/24
security.put_role 🔴 38/39 38/38

You can validate these APIs yourself by using the make validate target.

@slobodanadamovic
[Serverless] Update role name description (#2888)
c25af2c 
This commit updates the role name parameter description to point out the restrictions we have in Serverless.
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024

Following you can find the validation results for the APIs you have changed.

API Status Request Response
security.delete_role 🟢 8/8 8/8
security.get_builtin_privileges 🔴 2/2 1/2
security.get_role 🔴 24/24 21/24
security.put_role 🔴 38/39 38/38

You can validate these APIs yourself by using the make validate target.

@n1v0lg n1v0lg marked this pull request as ready for review October 10, 2024 12:06
@n1v0lg n1v0lg requested a review from pquentin October 10, 2024 12:06
@github-actions GitHub Actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
security.delete_role 🟢 8/8 8/8
security.get_builtin_privileges 🔴 2/2 1/2
security.get_role 🔴 24/24 21/24
security.put_role 🔴 38/39 38/38

You can validate these APIs yourself by using the make validate target.

pquentin
pquentin approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@n1v0lg n1v0lg merged commit d6f6e2f into main Oct 10, 2024
6 checks passed
@n1v0lg n1v0lg deleted the mark-role-apis-serverless-available branch October 10, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pquentin pquentin pquentin approved these changes

Assignees

@n1v0lg n1v0lg

Labels
specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@n1v0lg @pquentin @slobodanadamovic