Skip to content

Updating put_synonyms api specification #2789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Conversation

Samiul-TheSoccerFan
Copy link
Contributor

With the recent changes, put_synonmys can now support both list and object. Updating he specification to reflect the change.

Copy link
Contributor

Following you can find the validation results for the API you have changed.

API Status Request Response
synonyms.put_synonym 🟢 27/27 27/27

You can validate this API yourself by using the make validate target.

@Samiul-TheSoccerFan Samiul-TheSoccerFan marked this pull request as ready for review August 15, 2024 15:48
@Samiul-TheSoccerFan Samiul-TheSoccerFan changed the title updating put synonmys api specification Updating put_synonyms api specification Aug 15, 2024
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@pquentin pquentin merged commit 9ee10cc into main Aug 15, 2024
7 checks passed
@pquentin pquentin deleted the update-put-synonmys-api branch August 15, 2024 16:45
@Mikep86
Copy link

Mikep86 commented Aug 15, 2024

@pquentin Does this spec change need to be backported?

@pquentin
Copy link
Member

Good point! I applied the backport 8.14 and backport 8.15 labels to do so. Thank you.

github-actions bot pushed a commit that referenced this pull request Aug 15, 2024
github-actions bot pushed a commit that referenced this pull request Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants