-
Notifications
You must be signed in to change notification settings - Fork 102
Fix hot threads to always return strings #2793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also remove the HotThread
type.
This is done already, did I miss something? |
I think we missed the change because we thought the hidden file was an output file ^^" LGTM! |
(cherry picked from commit fd18fea)
(cherry picked from commit fd18fea)
(cherry picked from commit fd18fea)
Closes #1206