Skip to content

Fix hot threads to always return strings #2793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

pquentin
Copy link
Member

Closes #1206

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
nodes.hot_threads 🟢 5/5 5/5

You can validate these APIs yourself by using the make validate target.

Copy link

@dadoonet dadoonet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ;)

Copy link
Member

@swallez swallez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also remove the HotThread type.

@pquentin
Copy link
Member Author

This is done already, did I miss something?

@l-trotta
Copy link
Contributor

I think we missed the change because we thought the hidden file was an output file ^^" LGTM!

@pquentin pquentin dismissed swallez’s stale review August 20, 2024 16:33

The removed file was hidden.

@pquentin pquentin merged commit fd18fea into main Aug 20, 2024
9 checks passed
@pquentin pquentin deleted the hot-threads-response-type branch August 20, 2024 16:44
github-actions bot pushed a commit that referenced this pull request Aug 20, 2024
github-actions bot pushed a commit that referenced this pull request Aug 20, 2024
github-actions bot pushed a commit that referenced this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Response content-type for nodes.hot_threads
4 participants