Skip to content

Add data_stream_lifecycle to Health API response #2801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 22, 2024

Conversation

pquentin
Copy link
Member

I noticed this error with make validate. I used the server source for stagnating_backing_indices which was missing from the example. Note that this indicator is not documented.

This comment was marked as outdated.

Copy link
Member

@flobernd flobernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left a few comments 🙂

pquentin and others added 2 commits August 22, 2024 11:32
Co-authored-by: Florian Bernd <[email protected]>

This comment was marked as outdated.

Copy link
Contributor

Following you can find the validation results for the API you have changed.

API Status Request Response
health_report 🟢 4/4 4/4

You can validate this API yourself by using the make validate target.

@pquentin
Copy link
Member Author

Great catches, thanks! Please take another look.

@pquentin pquentin requested a review from flobernd August 22, 2024 07:40
Copy link
Member

@flobernd flobernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good now 🙂 Thank you!

@pquentin pquentin merged commit d7c8eb5 into main Aug 22, 2024
6 checks passed
@pquentin pquentin deleted the health-report-response-dsl branch August 22, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants