Skip to content

Add exclude query rule type to specification #2803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

kderusso
Copy link
Member

The exclude query rule type will go live with 8.16.0, this PR updates the specification accordingly.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
query_rules.delete_rule 🟢 6/6 6/6
query_rules.delete_ruleset 🟢 7/7 7/7
query_rules.get_rule 🟢 5/5 5/5
query_rules.get_ruleset 🟢 8/8 8/8
query_rules.list_rulesets 🟢 7/7 7/7
query_rules.put_rule 🟢 7/7 7/7
query_rules.put_ruleset 🟢 13/13 13/13

You can validate these APIs yourself by using the make validate target.

@kderusso kderusso requested a review from pquentin August 22, 2024 18:30
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@pquentin pquentin merged commit 7369568 into main Aug 23, 2024
7 checks passed
@pquentin pquentin deleted the kderusso/query-rules-exclude branch August 23, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants