Skip to content

[DOCS] Add API docs feedback link #2805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2024
Merged

[DOCS] Add API docs feedback link #2805

merged 1 commit into from
Aug 23, 2024

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Aug 22, 2024 •
edited
Loading

This PR:

  • adds a feedback link to the Elasticsearch openAPI documents via an overlay, as described in https://docs.bump.sh/help/publish-documentation/feedback/. The feedback link creates an issue in the docs_content repo for now.
  • removes the output files from the "make overlay-docs", since I don't think there's value to checking them in and adds them to the .gitignore file

@lcawl lcawl added the OpenAPI label Aug 22, 2024
@lcawl lcawl marked this pull request as ready for review August 22, 2024 22:26
shainaraskas
shainaraskas approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given that you've previewed this and it's working, good to go! 🚀

@lcawl lcawl merged commit e8714f1 into main Aug 23, 2024
7 checks passed
@lcawl lcawl deleted the api-feedback branch August 23, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shainaraskas shainaraskas shainaraskas approved these changes

Assignees
No one assigned
Labels
OpenAPI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lcawl @shainaraskas