Skip to content

Add Delete geoip database configuration API #2824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

pquentin
Copy link
Member

Part of #2810, like #2815 and #2823. There's an output conflict with #2823 that I will fix when one of the two will have been merged.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ingest.delete_geoip_database 🟢 1/1 1/1

You can validate these APIs yourself by using the make validate target.

@pquentin pquentin merged commit 21ef232 into main Aug 28, 2024
7 checks passed
@pquentin pquentin deleted the ingest-delete-geoip-database branch August 28, 2024 14:13
Copy link
Contributor

The backport to 8.15 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.15 8.15
# Navigate to the new working tree
cd .worktrees/backport-8.15
# Create a new branch
git switch --create backport-2824-to-8.15
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 21ef23261b8bcfd6fbb544ab5df8484b3e86e039
# Push it to GitHub
git push --set-upstream origin backport-2824-to-8.15
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.15

Then, create a pull request where the base branch is 8.15 and the compare/head branch is backport-2824-to-8.15.

pquentin added a commit that referenced this pull request Aug 28, 2024
pquentin added a commit that referenced this pull request Aug 28, 2024
/**
* A comma-separated list of geoip database configurations to delete
*/
id?: Ids
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pquentin Is this really an optional parameter? This triggered a validation rule in my code generator.

The rule requires a mandatory parameter to be used in all available urls for an endpoint and an optional parameter to not be used in all available urls for an endpoint.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We currently have only one url for this endpoint:

"urls": [
        {
          "methods": [
            "DELETE"
          ],
          "path": "/_ingest/geoip/database/{id}"
        }
]

In other words: If that endpoint does not support an additional url like "/_ingest/geoip/database" (without the {id}), we should make the path parameter mandatory.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry! #2837 fixes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants