Add geo-grid ingest processor #2844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
pquentin
commented
Sep 2, 2024
Comment on lines
+407
to
+408
| geojson, | ||
| wkt |
There was a problem hiding this comment.
While the documentation says it should be GeoJSON and WKT, the YAML tests are using geojson and wkt. I talked to @craigtaverner who confirms that this processor was specifically designed to be case-insensitive so lowercase is OK.
flobernd
reviewed
Sep 3, 2024
| ignore_missing?: boolean | ||
| /** | ||
| * Which format to save the generated polygon in. | ||
| * @server_default GeoJSON |
There was a problem hiding this comment.
Let's use full lowercase here as well to match the enum value.
There was a problem hiding this comment.
Oops! Done in b7eaafb (#2844).
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 3, 2024
(cherry picked from commit e171d9f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While this does not turn any status to green, this fixes most of the currently reported errors for
ingest.put_pipelinerequests.