Add hits_time_in_millis and misses_time_in_millis to enrich stats #2845
Conversation
|
Following you can find the validation results for the API you have changed.
You can validate this API yourself by using the |
specification/enrich/stats/types.ts
Outdated
| @@ -38,6 +38,10 @@ export class CacheStats { | |||
| node_id: Id | |||
| count: integer | |||
| hits: integer | |||
| /* The amount of time in milliseconds spent fetching data from the cache on successful cache hits only. */ | |||
| hits_time_in_millis: long | |||
There was a problem hiding this comment.
We might want to use DurationValue<UnitMillis> here to carry additional semantics.
There was a problem hiding this comment.
Thanks, done in 1e187ac (#2845).
specification/enrich/stats/types.ts
Outdated
| misses: integer | ||
| /* The amount of time in milliseconds spent fetching data from the enrich index and updating the cache, on cache misses only. */ | ||
| misses_time_in_millis: long |
There was a problem hiding this comment.
Thanks, done in 1e187ac (#2845).
|
Following you can find the validation results for the API you have changed.
You can validate this API yourself by using the |
|
Following you can find the validation results for the API you have changed.
You can validate this API yourself by using the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.15 8.15
# Navigate to the new working tree
cd .worktrees/backport-8.15
# Create a new branch
git switch --create backport-2845-to-8.15
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ce74e928e9df6c9b73cee5a6ca90180c680718c7
# Push it to GitHub
git push --set-upstream origin backport-2845-to-8.15
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.15Then, create a pull request where the |
) * Add hits_time_in_millis and misses_time_in_millis to enrich stats * Switch to DurationValue<UnitMillis> (cherry picked from commit ce74e92)
This was done in elastic/elasticsearch#107579.
Unlike #2846, this went into 8.15, so I'll backport it. The two changes together will fix the enrich stats API response validation.