-
Notifications
You must be signed in to change notification settings - Fork 102
Add Redact processor #2858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Redact processor #2858
Conversation
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just wondering if we should introduce a GrokPattern alias to allow the clients to implement custom functionality for this type.
We could, but we would need to do that for the |
It would not be breaking for .NET and Java as we simplify to the aliased type by default. Not 100% sure if that's the case for Go as well. cc @Anaethelion |
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.15 8.15
# Navigate to the new working tree
cd .worktrees/backport-8.15
# Create a new branch
git switch --create backport-2858-to-8.15
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 39ba8e8550e75ed515c0fd76803738df3b8aafcb
# Push it to GitHub
git push --set-upstream origin backport-2858-to-8.15
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.15 Then, create a pull request where the |
* Add Redact processor * Add GrokPattern alias (cherry picked from commit 39ba8e8)
* Add Redact processor * Add GrokPattern alias (cherry picked from commit 39ba8e8)
When coupled with #2854, this makes all ingest APIs pass validation (specifically, a redact processor is used in
ingest.put_pipeline
andingest.simulate
)