Skip to content

Fix ingest statistics in cluster.info #2883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Fix ingest statistics in cluster.info #2883

merged 1 commit into from
Sep 11, 2024

Conversation

pquentin
Copy link
Member

Splitting IngestTotal in two allowed me to remove all optional fields. I have no idea if this can break typed clients or not.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
nodes.clear_repositories_metering_archive Missing test Missing test
nodes.get_repositories_metering_info Missing test Missing test
nodes.hot_threads 🟢 5/5 5/5
nodes.info 🔴 116/116 1/116
nodes.reload_secure_settings 🟢 2/2 2/2
nodes.stats 🔴 52/52 14/52
nodes.usage 🟢 1/1 1/1

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

@l-trotta l-trotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and the java client

@pquentin pquentin merged commit c982446 into main Sep 11, 2024
7 checks passed
@pquentin pquentin deleted the ingest-stats branch September 11, 2024 16:55
github-actions bot pushed a commit that referenced this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants