Skip to content

Add minimum_should_match to terms_set #2901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

mspielberg
Copy link
Contributor

@mspielberg mspielberg commented Sep 17, 2024

Elasticsearch has supported the minimum_should_match parameter to terms_set since 8.10.0 (see elastic/elasticsearch#96082), but it is not reflected here, so the parameter is not exposed in the autogenerated clients.

Closes #2908

Copy link

cla-checker-service bot commented Sep 17, 2024

💚 CLA has been signed

@mspielberg
Copy link
Contributor Author

I have signed the CLA, but it does not appear to be (yet?) reflected by the automation.

@mspielberg mspielberg force-pushed the terms_set-minimum_should_match branch from b63c8b2 to d360ce9 Compare September 18, 2024 03:09
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@pquentin pquentin merged commit b1400a3 into elastic:main Sep 18, 2024
12 of 13 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 18, 2024
* Add minimum_should_match to terms_set

* Add availability annotations

* Run make contrib

---------

Co-authored-by: Quentin Pradet <[email protected]>
(cherry picked from commit b1400a3)
github-actions bot pushed a commit that referenced this pull request Sep 18, 2024
* Add minimum_should_match to terms_set

* Add availability annotations

* Run make contrib

---------

Co-authored-by: Quentin Pradet <[email protected]>
(cherry picked from commit b1400a3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants