Accept any FieldValue for terms_set #2906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 CLA has been signed |
mspielberg
force-pushed
the
terms_set-terms_type
branch
from
1ec67cf to
cb04179
Compare
|
Looks correct, we probably got this from the documentation, which says that |
|
Fine with not backporting this for now. For C# it's not a breaking change as we have an implicit conversion operator from string -> FieldValue. |
|
Also happy to not backport. |
|
As a side note, I already submitted elastic/elasticsearch#113043 to correct the documentation as well. |
l-trotta
approved these changes
Sep 23, 2024
|
correctly validated here, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
terms_setdefinition to accept any FieldValue, as thetermsquery already does, and as the Elasticsearch server implementation already does.This is not a breaking change at the Typescript level, as FieldValue includes
stringas one of its alternatives, but the materialization of the change may result in a breaking API change in specific language (e.g. Java) compiled clients.