Skip to content

[Backport][8.x] Add overlay for deep objects in ML analysis_config, datafeed_config, and transform source #2904 #2923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Sep 23, 2024

Backports #2904

This PR also updates the branch detail in the overlays (from main to 8.x) and adds the path-params rule to the .spectral linting rules. The latter is done so that this message can be downgraded from an error to a warning:

 24597:24  error  path-params  Paths "/_nodes/{node_id}" and "/_nodes/{metric}" must not be equivalent.  paths./_nodes/{metric}

@lcawl lcawl added the OpenAPI label Sep 23, 2024
@lcawl lcawl requested a review from esdocs September 23, 2024 17:42
@lcawl lcawl marked this pull request as ready for review September 23, 2024 20:40
Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lcawl lcawl merged commit 3f67248 into 8.x Sep 24, 2024
6 checks passed
@lcawl lcawl deleted the oas-overlays branch September 24, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants