Skip to content

Approximate snapshot verify integrity mapping #2930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

l-trotta
Copy link
Contributor

Mapping the new repository integrity verification API, allowing to merge the latest spec update without introducing new validation errors.

The query parameter max_bytes_per_sec is a string, but it has a specific format: <<size-units, size units>>. Considering it's the same in the DevTools I think we can keep it as a string for now.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
snapshot.repository_verify_integrity Missing test Missing test

You can validate these APIs yourself by using the make validate target.

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

Copy link
Member

@flobernd flobernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from my side as well.

@l-trotta l-trotta merged commit b394201 into main Sep 25, 2024
7 checks passed
@l-trotta l-trotta deleted the new-api-verify-integrity branch September 25, 2024 08:57
github-actions bot pushed a commit that referenced this pull request Sep 25, 2024
l-trotta added a commit that referenced this pull request Sep 25, 2024
(cherry picked from commit b394201)

Co-authored-by: Laura Trotta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants