Skip to content

Fix snapshot.create response #2931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Fix snapshot.create response #2931

merged 1 commit into from
Sep 24, 2024

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Sep 24, 2024

I'm not sure when this was added, but we only notice it now because of the new YAML test added in elastic/elasticsearch#113233.

This field is also used in snapshot.get.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
snapshot.cleanup_repository 🟢 3/3 3/3
snapshot.clone 🟢 5/5 5/5
snapshot.create_repository 🔴 24/29 29/29
snapshot.create 🟢 28/28 28/28
snapshot.delete_repository 🟢 10/10 10/10
snapshot.delete 🔴 21/23 23/23
snapshot.get_repository 🔴 19/19 7/19
snapshot.get 🟢 13/13 13/13
snapshot.repository_analyze 🟠 Missing type Missing type
snapshot.restore 🟢 5/5 5/5
snapshot.status 🟢 2/2 2/2
snapshot.verify_repository 🟢 2/2 2/2

You can validate these APIs yourself by using the make validate target.

@pquentin pquentin merged commit 030df6b into main Sep 24, 2024
7 checks passed
@pquentin pquentin deleted the fix-snapshot-create-response branch September 24, 2024 16:35
github-actions bot pushed a commit that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants