Skip to content

Fix ignored_field_values type #2934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Fix ignored_field_values type #2934

merged 1 commit into from
Sep 25, 2024

Conversation

pquentin
Copy link
Member

There are still three failing test on the search response side, this fixes one of them. In this YAML test, the ignored field value is:

{
  "key": "foo bar key",
  "value": "foo bar"
}

Copy link
Contributor

Following you can find the validation results for the API you have changed.

API Status Request Response
search 🔴 2180/2242 2222/2224

You can validate this API yourself by using the make validate target.

@pquentin pquentin merged commit 5ae90c2 into main Sep 25, 2024
8 checks passed
@pquentin pquentin deleted the fix-ignored-field-values branch September 25, 2024 09:02
github-actions bot pushed a commit that referenced this pull request Sep 25, 2024
github-actions bot pushed a commit that referenced this pull request Sep 25, 2024
pquentin added a commit that referenced this pull request Sep 25, 2024
(cherry picked from commit 5ae90c2)

Co-authored-by: Quentin Pradet <[email protected]>
pquentin added a commit that referenced this pull request Sep 25, 2024
(cherry picked from commit 5ae90c2)

Co-authored-by: Quentin Pradet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants