Replace DeploymentState with DeploymentAssignmentState #2942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svalbuena
force-pushed
the
svalb/fix_deployement_state
branch
from
d7ddbb2 to
dab0a09
Compare
|
Here is another bug I found in the ml model endpoints, atm this is failing in our production environment as we've built a detector for failing models that re-deploys them but we can't get the config back due to the deserialization error it throws. I'm using the .NET client but I suppose this issue is in all the clients generated from this spec. cc @pquentin @flobernd |
Closed
flobernd
force-pushed
the
svalb/fix_deployement_state
branch
from
dab0a09 to
f77291f
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Sep 27, 2024
(cherry picked from commit 9332d2b)
l-trotta
pushed a commit
that referenced
this pull request
Sep 27, 2024
(cherry picked from commit 9332d2b) Co-authored-by: Sergi Valbuena Garrido <[email protected]>
|
Thanks! When do you plan to release a new version of the .NET client? @flobernd |
|
@svalbuena Probably early next week 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2941.
While the server uses the AssignmentState enum for both the state and assignment_state fields, the spec defines two different enums (DeploymentState and DeploymentAssignmentState) for it and one of them has not been updated with all the possible values:
assignment_statefield is serialized here and it is of type AssignmentState.statefield is serialized here and it is of type AssignmentState too (this is the one I'm raising the issue for).In this PR I've replaced
TrainedModel.DeploymentStatewithTrainedModel.DeploymentAssignmentStateso that the spec is aligned with the server model and added comments to the cases ofTrainedModel.DeploymentAssignmentState.