Skip to content

Fetch JSON spec from Artifacts Snapshot API #2949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

pquentin
Copy link
Member

We were still using the Artifacts API, which has no notion of "8.x", which is why builds were still failing: https://github.com/elastic/elasticsearch-specification/actions/runs/11064313424/job/30741882039.

This can be tested with:

make setup
npm install .github/download-artifacts
node .github/download-artifacts/index.js --branch 8.x
git status   # notice that we did change specification/_json_spec, it's just not formatted yet
make contrib
git status   # after formatting, there's no change left

@@ -37,7 +37,7 @@ jobs:

- name: Generate output
run: |
SKIP_VERSION_UPDATE=true make contrib
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This had no effect for some time now.

Comment on lines -175 to +125
string: ['id', 'version', 'hash', 'branch']
string: ['branch']
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only use --branch now.


core.info(`Resolving version ${version}`)
const response = await fetch(`https://artifacts-api.elastic.co/v1/versions/${version}`)
async function resolve (branch) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is largely copied over from clients-flight-recorder.

@pquentin pquentin requested review from Anaethelion, l-trotta and JoshMock and removed request for Anaethelion September 27, 2024 06:48
@pquentin pquentin merged commit 0464df5 into main Oct 1, 2024
6 checks passed
@pquentin pquentin deleted the fix-download-artifacts-8.x branch October 1, 2024 02:57
Copy link
Contributor

github-actions bot commented Oct 1, 2024

The backport to 7.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.17 7.17
# Navigate to the new working tree
cd .worktrees/backport-7.17
# Create a new branch
git switch --create backport-2949-to-7.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0464df58867761123eec71e31bde5575189fceb3
# Push it to GitHub
git push --set-upstream origin backport-2949-to-7.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.17

Then, create a pull request where the base branch is 7.17 and the compare/head branch is backport-2949-to-7.17.

Copy link
Contributor

github-actions bot commented Oct 1, 2024

The backport to 8.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.x 8.x
# Navigate to the new working tree
cd .worktrees/backport-8.x
# Create a new branch
git switch --create backport-2949-to-8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0464df58867761123eec71e31bde5575189fceb3
# Push it to GitHub
git push --set-upstream origin backport-2949-to-8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.x

Then, create a pull request where the base branch is 8.x and the compare/head branch is backport-2949-to-8.x.

Copy link
Contributor

github-actions bot commented Oct 1, 2024

The backport to 8.15 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.15 8.15
# Navigate to the new working tree
cd .worktrees/backport-8.15
# Create a new branch
git switch --create backport-2949-to-8.15
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0464df58867761123eec71e31bde5575189fceb3
# Push it to GitHub
git push --set-upstream origin backport-2949-to-8.15
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.15

Then, create a pull request where the base branch is 8.15 and the compare/head branch is backport-2949-to-8.15.

pquentin added a commit that referenced this pull request Oct 1, 2024
pquentin added a commit that referenced this pull request Oct 1, 2024
pquentin added a commit that referenced this pull request Oct 1, 2024
pquentin added a commit that referenced this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants