Add trace_redact to RedactProcessor #2965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
l-trotta
approved these changes
Sep 30, 2024
flobernd
approved these changes
Sep 30, 2024
| @@ -27,10 +27,20 @@ import { ErrorCause } from '@_types/Errors' | |||
| import { DateTime } from '@_types/Time' | |||
|
|
|||
| export class Ingest { | |||
| _redact?: Redact | |||
There was a problem hiding this comment.
Should we add an availability annotation here as well? It probably makes no sense to have an empty class in pre 8.16 versions e.g. in case this gets backported.
There was a problem hiding this comment.
wait how could this get backported to 8.15?
There was a problem hiding this comment.
In any case it does make sense to add the annotation at this level I think?
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 30, 2024
* Add trace_redact to RedactProcessor * Move availability annotation (cherry picked from commit 593ad71)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As added in elastic/elasticsearch#113552.