Skip to content

Fixing snapshot restore response #2999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conversation

l-trotta
Copy link
Contributor

@l-trotta l-trotta commented Oct 9, 2024

This is one of the many endpoints which changes its response depending if wait_for_completion was set as true or false in the request. server code

Copy link
Contributor

github-actions bot commented Oct 9, 2024

Following you can find the validation results for the API you have changed.

API Status Request Response
snapshot.restore 🟢 5/5 5/5

You can validate this API yourself by using the make validate target.

Copy link
Member

@flobernd flobernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I guess that's the only viable solution for now.

@l-trotta l-trotta merged commit 9db9572 into main Oct 10, 2024
9 checks passed
@l-trotta l-trotta deleted the fix-snapshot-restore-response branch October 10, 2024 08:45
Copy link
Contributor

The backport to 7.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.17 7.17
# Navigate to the new working tree
cd .worktrees/backport-7.17
# Create a new branch
git switch --create backport-2999-to-7.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9db95724accd9739f09c165fc1e119261d0fe064
# Push it to GitHub
git push --set-upstream origin backport-2999-to-7.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.17

Then, create a pull request where the base branch is 7.17 and the compare/head branch is backport-2999-to-7.17.

github-actions bot pushed a commit that referenced this pull request Oct 10, 2024
(cherry picked from commit 9db9572)
github-actions bot pushed a commit that referenced this pull request Oct 10, 2024
(cherry picked from commit 9db9572)
l-trotta added a commit that referenced this pull request Oct 10, 2024
(cherry picked from commit 9db9572)

Co-authored-by: Laura Trotta <[email protected]>
l-trotta added a commit that referenced this pull request Oct 10, 2024
(cherry picked from commit 9db9572)

Co-authored-by: Laura Trotta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants