Update Serverless scope for legacy put_template #3005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
pquentin
reviewed
Oct 10, 2024
| @@ -26,7 +26,7 @@ import { Duration } from '@_types/Time' | |||
| * Returns information about the tasks currently executing in the cluster. | |||
| * @rest_spec_name tasks.get | |||
| * @availability stack since=5.0.0 stability=experimental | |||
| * @availability serverless stability=experimental visibility=public | |||
| * @availability serverless stability=experimental visibility=private | |||
There was a problem hiding this comment.
Suggested change
| * @availability serverless stability=experimental visibility=private | |
| * @availability serverless stability=experimental visibility=public |
tasks.get is public, but tasks.list is not, but this is already correct:
There was a problem hiding this comment.
I finally found why this wasn't making sense to me 😅
The Ruby code generator had a bug and task.get didn't have id as required so I was testing the tasks.list path (without an id) 🤦
specification/indices/put_template/IndicesPutTemplateRequest.ts
Outdated
Show resolved
Hide resolved
From @pquentin's research: indices.put_template The /_template URLs refer to legacy index templates, that are not available on Serverless. Actions without an annotation are unavailable on Serverless. The only possible Scope values are PUBLIC and INTERNAL, unavailable is marked by the absence of an annotation.
picandocodigo
force-pushed
the
serverless_apis
branch
from
5e92555 to
7e7836a
Compare
|
Following you can find the validation results for the API you have changed.
You can validate this API yourself by using the |
picandocodigo
changed the title
|
Thanks @pquentin, I updated the PR so that it's just removing the scope for serverless in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From @pquentin's research:
tasks.get- This one is not actuallytasks.get(with endpoint/_tasks/{task_id}), it'stasks.list(with endpoint/_tasks/), which is INTERNAL.indices.put_template- The /_template URLs refer to legacy index templates, that are not available on Serverless.