Skip to content

[Backport 8.x] Make Inference API task_settings optional #3008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 14, 2024
Merged

[Backport 8.x] Make Inference API task_settings optional #3008

merged 2 commits into from
Oct 14, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Backport de300c8 from #2994.

@github-actions GitHub Actions
Copy link
Contributor Author

Following you can find the validation results for the APIs you have changed.

API Status Request Response
inference.delete ⚪ Missing test Missing test
inference.get 🟢 4/4 4/4
inference.inference ⚪ Missing test Missing test
inference.put ⚪ Missing test Missing test
inference.stream_inference 🟠 Missing type Missing type

You can validate these APIs yourself by using the make validate target.

@pquentin pquentin closed this Oct 11, 2024
@pquentin pquentin reopened this Oct 11, 2024
@github-actions GitHub Actions
Copy link
Contributor Author

Following you can find the validation results for the APIs you have changed.

API Status Request Response
inference.delete ⚪ Missing test Missing test
inference.get 🟢 4/4 4/4
inference.inference ⚪ Missing test Missing test
inference.put ⚪ Missing test Missing test
inference.stream_inference 🟠 Missing type Missing type

You can validate these APIs yourself by using the make validate target.

@l-trotta l-trotta merged commit 13c2168 into 8.x Oct 14, 2024
12 checks passed
@l-trotta l-trotta deleted the backport-2994-to-8.x branch October 14, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l-trotta l-trotta l-trotta approved these changes

Assignees
No one assigned
Labels
specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@l-trotta @pquentin @davidkyle