Skip to content

[Backport 8.x] Add terminate ingest processor #3009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Conversation

github-actions[bot]
Copy link
Contributor

Backport bcfdc95 from #3003.

(cherry picked from commit bcfdc95)
@PeteGillinElastic
Copy link
Member

It looks like this backport needs a review, if someone would be so kind.

@pquentin pquentin closed this Oct 11, 2024
auto-merge was automatically disabled October 11, 2024 10:01

Pull request was closed

@pquentin pquentin reopened this Oct 11, 2024
Copy link
Contributor Author

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ingest.delete_geoip_database 🟢 1/1 1/1
ingest.delete_pipeline 🟢 15/15 15/15
ingest.geo_ip_stats 🟢 1/1 1/1
ingest.get_geoip_database 🟢 6/6 6/6
ingest.get_pipeline 🟢 22/22 22/22
ingest.processor_grok 🟢 1/1 1/1
ingest.put_geoip_database 🟢 3/3 3/3
ingest.put_pipeline 🟢 59/59 59/59
ingest.simulate 🟢 10/10 10/10

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor Author

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ingest.delete_geoip_database 🟢 1/1 1/1
ingest.delete_pipeline 🟢 15/15 15/15
ingest.geo_ip_stats 🟢 1/1 1/1
ingest.get_geoip_database 🟢 6/6 6/6
ingest.get_pipeline 🟢 22/22 22/22
ingest.processor_grok 🟢 1/1 1/1
ingest.put_geoip_database 🟢 3/3 3/3
ingest.put_pipeline 🟢 59/59 59/59
ingest.simulate 🟢 10/10 10/10

You can validate these APIs yourself by using the make validate target.

@pquentin pquentin merged commit a1e3919 into 8.x Oct 11, 2024
6 checks passed
@pquentin pquentin deleted the backport-3003-to-8.x branch October 11, 2024 10:15
@pquentin
Copy link
Member

Thank you!

@PeteGillinElastic
Copy link
Member

Thanks @pquentin . Out of interest, is make contrib something I should have known about myself? (I didn't do it on the PR on main, but I think the bot came along and updated the specification output afterwards.)

@pquentin
Copy link
Member

pquentin commented Oct 11, 2024

Yes automation takes care of it on main, however I was not sure it would work on a branch so I ran it just in case. Not something you should care about yourself.

Thanks for asking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants