Skip to content

Update doc comments guidelines #3037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

flobernd
Copy link
Member

@flobernd flobernd commented Oct 22, 2024

Update doc comments guidelines to ensure the best looking output in OpenAPI as well as in all other places which are using Markdown rendering.

The blank line creates a proper paragraph in all places other than the OpenAPI output - e.g. the in-code documentation of the generated clients. Without this, the text looks very squashed.

@flobernd flobernd requested review from swallez, lcawl and a team October 22, 2024 07:00
Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me

@flobernd flobernd merged commit ddf9cd9 into main Oct 22, 2024
6 checks passed
@flobernd flobernd deleted the update-doc-comments-guidelines branch October 22, 2024 18:00
pquentin pushed a commit that referenced this pull request Jan 2, 2025
@pquentin
Copy link
Member

pquentin commented Jan 2, 2025

💚 All backports created successfully

Status Branch Result
8.x

Questions ?

Please refer to the Backport tool documentation

pquentin added a commit that referenced this pull request Jan 2, 2025
(cherry picked from commit ddf9cd9)

Co-authored-by: Florian Bernd <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants