-
Notifications
You must be signed in to change notification settings - Fork 102
Fix additional property name for TermsQuery
#3038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm not using the key and value names, just their types, so for the Python DSL client this is fine 👍 |
|
It's not implemented yet in the Java generator, so no problem. |
(cherry picked from commit 16130b9)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.16 8.16
# Navigate to the new working tree
cd .worktrees/backport-8.16
# Create a new branch
git switch --create backport-3038-to-8.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 16130b9a2f165a445d3201043ea47278eed1c164
# Push it to GitHub
git push --set-upstream origin backport-3038-to-8.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.16 Then, create a pull request where the |
(cherry picked from commit 16130b9) Co-authored-by: Florian Bernd <[email protected]>
This seems to be a copy/paste mistake made by me when I implemented the
behavior_meta
tag.@swallez @Anaethelion @ezimuel @picandocodigo @miguelgrinberg @l-trotta @pquentin @JoshMock Please check, if this is a breaking change in any of your clients. Most likely only the static language clients should be affected - if at all.