Skip to content

Fix additional property name for TermsQuery #3038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Conversation

flobernd
Copy link
Member

@flobernd flobernd commented Oct 22, 2024

This seems to be a copy/paste mistake made by me when I implemented the behavior_meta tag.

@swallez @Anaethelion @ezimuel @picandocodigo @miguelgrinberg @l-trotta @pquentin @JoshMock Please check, if this is a breaking change in any of your clients. Most likely only the static language clients should be affected - if at all.

@flobernd flobernd requested a review from a team October 22, 2024 07:38
@miguelgrinberg
Copy link
Contributor

miguelgrinberg commented Oct 22, 2024

I'm not using the key and value names, just their types, so for the Python DSL client this is fine 👍

@JoshMock
Copy link
Member

AdditionalProperty behaviors are currently ignored by JS codegen. 👍

@swallez
Copy link
Member

swallez commented Oct 23, 2024

It's not implemented yet in the Java generator, so no problem.

@flobernd flobernd merged commit 16130b9 into main Oct 23, 2024
8 checks passed
@flobernd flobernd deleted the fix-terms-query-terms-name branch October 23, 2024 11:28
github-actions bot pushed a commit that referenced this pull request Oct 23, 2024
Copy link
Contributor

The backport to 8.16 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.16 8.16
# Navigate to the new working tree
cd .worktrees/backport-8.16
# Create a new branch
git switch --create backport-3038-to-8.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 16130b9a2f165a445d3201043ea47278eed1c164
# Push it to GitHub
git push --set-upstream origin backport-3038-to-8.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.16

Then, create a pull request where the base branch is 8.16 and the compare/head branch is backport-3038-to-8.16.

flobernd added a commit that referenced this pull request Oct 23, 2024
(cherry picked from commit 16130b9)

Co-authored-by: Florian Bernd <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants