Improve SearchApplication definition (and related)
#3040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
flobernd
force-pushed
the
improve-search-application-spec
branch
from
34c9616 to
ed55594
Compare
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
JoshMock
approved these changes
Oct 22, 2024
pquentin
pushed a commit
that referenced
this pull request
Jan 2, 2025
(cherry picked from commit 2d0a0fd)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
pquentin
added a commit
that referenced
this pull request
Jan 2, 2025
(cherry picked from commit 2d0a0fd) Co-authored-by: Florian Bernd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SearchApplicationwas used as the body forsearch_application.putas well assearch_application.get.This caused problems, because the
namefield was mandatory, but is actually not required in case ofPUT.In this PR, I remove
namefromSearchApplicationand rename this type toSearchApplicationParameters.The current
SearchApplicationnow derives fromSearchApplicationParametersand adds back thenamefield. This type is used as the response forsearch_application.getandsearch_application.list(instead ofSearchApplicationListItemwhich became redundant).