Skip to content

[OpenAPI] Add more x-model and @ext_doc_id values #3048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 23, 2024
Merged

[OpenAPI] Add more x-model and @ext_doc_id values #3048

merged 3 commits into from
Oct 23, 2024

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Oct 22, 2024

This PR adds more @ext_doc_id values and more x-model overlays for deeply nested Elasticsearch schema objects.

It also adds a comment in the introduction about the "work-in-progress" state of content on the "main" branch, to match what's in our other docs.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
msearch 🟢 17/17 16/16
search 🔴 2213/2273 2254/2255

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl requested a review from esdocs October 22, 2024 23:00
@lcawl lcawl marked this pull request as ready for review October 22, 2024 23:00
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
msearch 🟢 17/17 16/16
search 🔴 2213/2273 2254/2255

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
msearch 🟢 17/17 16/16
search 🔴 2213/2273 2254/2255

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl lcawl merged commit dad2aa1 into main Oct 23, 2024
6 checks passed
@lcawl lcawl deleted the lcawl/x-model branch October 23, 2024 22:02
github-actions bot pushed a commit that referenced this pull request Oct 23, 2024
github-actions bot pushed a commit that referenced this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants