Skip to content

Add Elasticsearch specification for query rules retriever #3078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 4, 2024

Conversation

kderusso
Copy link
Member

Adds the query rules retriever to the Elasticsearch specification, defined in elastic/elasticsearch#114855

@kderusso kderusso marked this pull request as ready for review October 29, 2024 18:45
@Anaethelion Anaethelion self-requested a review November 4, 2024 13:53
Copy link
Contributor

@Anaethelion Anaethelion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kderusso kderusso enabled auto-merge (squash) November 4, 2024 18:14
@kderusso kderusso merged commit 57ca93f into main Nov 4, 2024
6 checks passed
@kderusso kderusso deleted the kderusso/query-rules-retriever branch November 4, 2024 18:15
Copy link
Contributor

github-actions bot commented Nov 4, 2024

The backport to 8.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.x 8.x
# Navigate to the new working tree
cd .worktrees/backport-8.x
# Create a new branch
git switch --create backport-3078-to-8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 57ca93fb362d9f1e1ff940938a1113133bad220c
# Push it to GitHub
git push --set-upstream origin backport-3078-to-8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.x

Then, create a pull request where the base branch is 8.x and the compare/head branch is backport-3078-to-8.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants