-
Notifications
You must be signed in to change notification settings - Fork 102
[OpenAPI] Edits the autoscaling APIs #3081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blind faith review! But I think I found one typo :)
...oscaling/get_autoscaling_capacity/autoscalingApisGetAutoscalingCapacityResponseExample1.yaml
Outdated
Show resolved
Hide resolved
…ApisGetAutoscalingCapacityResponseExample1.yaml Co-authored-by: Liam Thompson <[email protected]>
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
1 similar comment
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.x 8.x
# Navigate to the new working tree
cd .worktrees/backport-8.x
# Create a new branch
git switch --create backport-3081-to-8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b0860fca5b1e7049848d622b31481ff5f02a1a47
# Push it to GitHub
git push --set-upstream origin backport-3081-to-8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.16 8.16
# Navigate to the new working tree
cd .worktrees/backport-8.16
# Create a new branch
git switch --create backport-3081-to-8.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b0860fca5b1e7049848d622b31481ff5f02a1a47
# Push it to GitHub
git push --set-upstream origin backport-3081-to-8.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.16 Then, create a pull request where the |
Co-authored-by: Liam Thompson <[email protected]>
Co-authored-by: Liam Thompson <[email protected]>
Co-authored-by: Liam Thompson <[email protected]>
Co-authored-by: Liam Thompson <[email protected]>
This PR edits the text to align with https://www.elastic.co/guide/en/elasticsearch/reference/master/autoscaling-apis.html.
It also changes the examples from .json to .yaml files and adds them to the overlays.
Review notes
Since the openAPI document is too big for previews and not hooked into buildkite previews yet, if reviewers are wanting to review the strings, they all appear in the output/openapi/elasticsearch-openapi.json file.