Skip to content

Add support for new timezone field in watch schedules #3181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

lukewhiting
Copy link
Contributor

@lukewhiting lukewhiting commented Nov 26, 2024

This change adds timezone support to Watcher schedules added in elastic/elasticsearch#117033

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
watcher.ack_watch 🟢 1/1 1/1
watcher.activate_watch 🟢 1/1 1/1
watcher.deactivate_watch 🟢 1/1 1/1
watcher.delete_watch 🟢 2/2 2/2
watcher.execute_watch 🟢 7/7 7/7
watcher.get_settings 🟠 Missing type Missing type
watcher.get_watch 🟢 9/9 9/9
watcher.put_watch 🔴 29/38 38/38
watcher.query_watches Missing test Missing test
watcher.start 🟢 1/1 1/1
watcher.stats 🟢 1/1 1/1
watcher.stop 🟢 1/1 1/1
watcher.update_settings 🟠 Missing type Missing type

You can validate these APIs yourself by using the make validate target.

@lukewhiting lukewhiting force-pushed the add-watcher-tz-support branch from df4d22b to d7ca934 Compare November 26, 2024 13:00
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
watcher.ack_watch 🟢 1/1 1/1
watcher.activate_watch 🟢 1/1 1/1
watcher.deactivate_watch 🟢 1/1 1/1
watcher.delete_watch 🟢 2/2 2/2
watcher.execute_watch 🟢 7/7 7/7
watcher.get_settings 🟠 Missing type Missing type
watcher.get_watch 🟢 9/9 9/9
watcher.put_watch 🔴 29/38 38/38
watcher.query_watches Missing test Missing test
watcher.start 🟢 1/1 1/1
watcher.stats 🟢 1/1 1/1
watcher.stop 🟢 1/1 1/1
watcher.update_settings 🟠 Missing type Missing type

You can validate these APIs yourself by using the make validate target.

@lukewhiting
Copy link
Contributor Author

I'm trying to run the validation locally (Ubuntu 24.04) to get more info about the fails on the watcher.put_watch endpoint however I get this when running make validate api=watcher.put_watch type=request branch=main:

✖ 
    at run (/home/lukewhiting/code/elasticsearch-specification/compiler/run-validations.js:114:12)
    exit code: 1
make: *** [Makefile:4: validate] Error 1

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! The failures are unrelated (#3188 fixes most of them), and I'll reach out to you offline to fix make validate.

This change isn't tested because we don't currently use the watcher plugin from the Elasticsearch YAML tests, but I'd love to do it at some point.

@pquentin pquentin merged commit b8e3cf6 into main Nov 27, 2024
7 checks passed
@pquentin pquentin deleted the add-watcher-tz-support branch November 27, 2024 05:47
Copy link
Contributor

The backport to 8.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.x 8.x
# Navigate to the new working tree
cd .worktrees/backport-8.x
# Create a new branch
git switch --create backport-3181-to-8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b8e3cf63b0432eed31014a2900eac5d791962edc
# Push it to GitHub
git push --set-upstream origin backport-3181-to-8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.x

Then, create a pull request where the base branch is 8.x and the compare/head branch is backport-3181-to-8.x.

@pquentin
Copy link
Member

💚 All backports created successfully

Status Branch Result
8.x

Questions ?

Please refer to the Backport tool documentation

pquentin pushed a commit to pquentin/elasticsearch-specification that referenced this pull request Nov 27, 2024
pquentin pushed a commit that referenced this pull request Nov 27, 2024
@pquentin
Copy link
Member

💚 All backports created successfully

Status Branch Result
8.x

Questions ?

Please refer to the Backport tool documentation

pquentin added a commit that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants