-
Notifications
You must be signed in to change notification settings - Fork 102
Add support for new timezone field in watch schedules #3181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
df4d22b
to
d7ca934
Compare
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
I'm trying to run the validation locally (Ubuntu 24.04) to get more info about the fails on the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! The failures are unrelated (#3188 fixes most of them), and I'll reach out to you offline to fix make validate
.
This change isn't tested because we don't currently use the watcher plugin from the Elasticsearch YAML tests, but I'd love to do it at some point.
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.x 8.x
# Navigate to the new working tree
cd .worktrees/backport-8.x
# Create a new branch
git switch --create backport-3181-to-8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b8e3cf63b0432eed31014a2900eac5d791962edc
# Push it to GitHub
git push --set-upstream origin backport-3181-to-8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.x Then, create a pull request where the |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
(cherry picked from commit b8e3cf6)
(cherry picked from commit b8e3cf6)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
…3190) Co-authored-by: Luke Whiting <[email protected]>
This change adds timezone support to Watcher schedules added in elastic/elasticsearch#117033