Skip to content

[DOCS] Edit Fleet operation summaries #3227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 4, 2024
Merged

[DOCS] Edit Fleet operation summaries #3227

merged 5 commits into from
Dec 4, 2024

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Dec 4, 2024

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Following you can find the validation results for the APIs you have changed.

API Status Request Response
fleet.global_checkpoints Missing test Missing test
fleet.msearch Missing test Missing test
fleet.search Missing test Missing test

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

@marciw marciw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ a couple of tiny typos

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Following you can find the validation results for the APIs you have changed.

API Status Request Response
fleet.global_checkpoints Missing test Missing test
fleet.msearch Missing test Missing test
fleet.search Missing test Missing test

You can validate these APIs yourself by using the make validate target.

1 similar comment
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Following you can find the validation results for the APIs you have changed.

API Status Request Response
fleet.global_checkpoints Missing test Missing test
fleet.msearch Missing test Missing test
fleet.search Missing test Missing test

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Following you can find the validation results for the APIs you have changed.

API Status Request Response
fleet.global_checkpoints Missing test Missing test
fleet.msearch Missing test Missing test
fleet.search Missing test Missing test

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl enabled auto-merge (squash) December 4, 2024 22:58
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Following you can find the validation results for the APIs you have changed.

API Status Request Response
fleet.global_checkpoints Missing test Missing test
fleet.msearch Missing test Missing test
fleet.search Missing test Missing test

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl merged commit 355291a into main Dec 4, 2024
7 checks passed
@lcawl lcawl deleted the fleet-summary branch December 4, 2024 22:59
Copy link
Contributor

github-actions bot commented Dec 4, 2024

The backport to 8.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.x 8.x
# Navigate to the new working tree
cd .worktrees/backport-8.x
# Create a new branch
git switch --create backport-3227-to-8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 355291a78367fa241467e009d4470d8e01a2ddad
# Push it to GitHub
git push --set-upstream origin backport-3227-to-8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.x

Then, create a pull request where the base branch is 8.x and the compare/head branch is backport-3227-to-8.x.

Copy link
Contributor

github-actions bot commented Dec 4, 2024

The backport to 8.16 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.16 8.16
# Navigate to the new working tree
cd .worktrees/backport-8.16
# Create a new branch
git switch --create backport-3227-to-8.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 355291a78367fa241467e009d4470d8e01a2ddad
# Push it to GitHub
git push --set-upstream origin backport-3227-to-8.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.16

Then, create a pull request where the base branch is 8.16 and the compare/head branch is backport-3227-to-8.16.

Copy link
Contributor

github-actions bot commented Dec 4, 2024

The backport to 8.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.17 8.17
# Navigate to the new working tree
cd .worktrees/backport-8.17
# Create a new branch
git switch --create backport-3227-to-8.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 355291a78367fa241467e009d4470d8e01a2ddad
# Push it to GitHub
git push --set-upstream origin backport-3227-to-8.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.17

Then, create a pull request where the base branch is 8.17 and the compare/head branch is backport-3227-to-8.17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants