Skip to content

Add find field structure and find messages structure APIs #3346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 19, 2024

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Dec 18, 2024

@lcawl lcawl requested a review from a team December 18, 2024 00:14
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
text_structure.find_field_structure 🟠 Missing type Missing type
text_structure.find_message_structure 🟠 Missing type Missing type
text_structure.find_structure 🟢 2/2 2/2

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
text_structure.find_field_structure 🟢 1/1 1/1
text_structure.find_message_structure 🟢 2/2 2/2
text_structure.find_structure 🟢 2/2 2/2

You can validate these APIs yourself by using the make validate target.

Copy link
Member

@flobernd flobernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 🙂 Left a few type related suggestions.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
text_structure.find_field_structure 🟢 1/1 1/1
text_structure.find_message_structure 🟢 2/2 2/2
text_structure.find_structure 🟢 2/2 2/2
text_structure.test_grok_pattern 🟢 2/2 2/2

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl merged commit 4b93d7f into main Dec 19, 2024
9 checks passed
@lcawl lcawl deleted the text-structure-missing branch December 19, 2024 17:42
github-actions bot pushed a commit that referenced this pull request Dec 19, 2024
github-actions bot pushed a commit that referenced this pull request Dec 19, 2024
lcawl added a commit that referenced this pull request Dec 19, 2024
)

Co-authored-by: Florian Bernd <[email protected]>
(cherry picked from commit 4b93d7f)

Co-authored-by: Lisa Cawley <[email protected]>
lcawl added a commit that referenced this pull request Dec 19, 2024
)

Co-authored-by: Florian Bernd <[email protected]>
(cherry picked from commit 4b93d7f)

Co-authored-by: Lisa Cawley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants