Skip to content

Add shard_failures to EQL response spec #3372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2024
Merged

Add shard_failures to EQL response spec #3372

merged 1 commit into from
Dec 21, 2024

Conversation

luigidellaquila
Copy link
Contributor

Adding shard_failures to the EQL response specification

Related to elastic/elasticsearch#116388
Follow-up to #3342

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
eql.delete 🟢 3/3 3/3
eql.get_status 🟢 3/3 3/3
eql.get 🟢 3/3 3/3
eql.search 🟢 37/37 37/37

You can validate these APIs yourself by using the make validate target.

@pquentin pquentin merged commit 9a0db4c into main Dec 21, 2024
8 checks passed
@pquentin pquentin deleted the eql_partial_results branch December 21, 2024 05:28
@dhurley14
Copy link

@luigidellaquila Does this need to be backported to 8.x as well?

@luigidellaquila
Copy link
Contributor Author

Uhm... yes, it needs a backport, thanks for pointing it out, I didn't realize I didn't do it.

@luigidellaquila
Copy link
Contributor Author

Added to my TODO list, I'll take care of it asap (unless there is some automation we can use on this repo)

@luigidellaquila
Copy link
Contributor Author

Created backport PR #3674

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants