Skip to content

Update rest-api-spec query parameters #3405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Jan 2, 2025

This updates all query parameters from #3263. We can't merge #3263 as is because it includes a new migrate API that is not in the specification yet. Many query parameter changes were motivated by #3297:

This also includes elastic/elasticsearch#116388, which should only be backported to 8.x, not earlier branches.

@pquentin pquentin requested a review from a team as a code owner January 2, 2025 11:17
Copy link
Contributor

github-actions bot commented Jan 2, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
slm.delete_lifecycle 🟢 4/4 4/4
slm.execute_lifecycle 🟢 4/4 4/4
slm.execute_retention 🟢 4/4 4/4
slm.get_lifecycle 🟢 16/16 16/16
slm.get_stats 🟢 4/4 4/4
slm.get_status 🟢 4/4 4/4
slm.start Missing test Missing test
slm.stop 🟢 4/4 4/4

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

github-actions bot commented Jan 3, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
slm.delete_lifecycle 🟢 4/4 4/4
slm.execute_lifecycle 🟢 4/4 4/4
slm.execute_retention 🟢 4/4 4/4
slm.get_lifecycle 🟢 16/16 16/16
slm.get_stats 🟢 4/4 4/4
slm.get_status 🟢 4/4 4/4
slm.start Missing test Missing test
slm.stop 🟢 4/4 4/4

You can validate these APIs yourself by using the make validate target.

@l-trotta l-trotta self-assigned this Jan 7, 2025
@pquentin pquentin merged commit 02bb34c into main Jan 8, 2025
9 checks passed
@pquentin pquentin deleted the update-json-spec-query-parmeters branch January 8, 2025 05:50
github-actions bot pushed a commit that referenced this pull request Jan 8, 2025
github-actions bot pushed a commit that referenced this pull request Jan 8, 2025
pquentin added a commit that referenced this pull request Jan 8, 2025
(cherry picked from commit 02bb34c)

Co-authored-by: Quentin Pradet <[email protected]>
pquentin added a commit that referenced this pull request Jan 8, 2025
* Update rest-api-spec query parameters (#3405)

(cherry picked from commit 02bb34c)

* Remove eql.search change from backport

---------

Co-authored-by: Quentin Pradet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants